Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(dds): Use tsc-multi to dual-emit CJS and ESM #18274

Merged
merged 52 commits into from Nov 16, 2023
Merged

build(dds): Use tsc-multi to dual-emit CJS and ESM #18274

merged 52 commits into from Nov 16, 2023

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Nov 13, 2023 •
edited

Updates the packages in /dds to use tsc-multi to build ESM and CJS with node16 module resolution.

This builds on top of #18264 so that PR needs to be merged first.

Guidance for reviewers

Focus on the changes in the packages/dds folder. The other changes are from #18264.

@github-actions github-actions bot added base: main PRs targeted against main branch area: build Build related issues area: dds Issues related to distributed data structures area: dds: sharedstring dependencies Pull requests that update a dependency file labels Nov 13, 2023
@github-actions github-actions bot added the area: tests Tests to add, test infrastructure improvements, etc label Nov 13, 2023
@github-actions github-actions bot added the area: loader Loader related issues label Nov 13, 2023
tylerbutler
tylerbutler commented Nov 15, 2023
View reviewed changes
fluidBuild.config.cjs Outdated Show resolved Hide resolved
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 16, 2023 •
edited

⯅ @fluid-example/bundle-size-tests: +14 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 447.53 KB 447.53 KB ⯅ +2 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 240.63 KB 240.63 KB ■ No change
loader.js 165.11 KB 165.12 KB ⯅ +2 Bytes
map.js 48.06 KB 48.06 KB ⯅ +2 Bytes
matrix.js 141.84 KB 141.85 KB ⯅ +2 Bytes
odspDriver.js 90.3 KB 90.3 KB ⯅ +2 Bytes
odspPrefetchSnapshot.js 41.82 KB 41.82 KB ⯅ +2 Bytes
sharedString.js 162.75 KB 162.75 KB ■ No change
sharedTree2.js 275.15 KB 275.15 KB ■ No change
Total Size 1.73 MB 1.73 MB ⯅ +14 Bytes

Baseline commit: b86a4e6

Generated by 🚫 dangerJS against f73a815

@tylerbutler tylerbutler marked this pull request as ready for review November 16, 2023 01:19
@tylerbutler tylerbutler requested review from msfluid-bot and a team as code owners November 16, 2023 01:19
@tylerbutler tylerbutler mentioned this pull request Nov 16, 2023
Merged
Josmithr
Josmithr reviewed Nov 16, 2023
View reviewed changes
packages/loader/container-loader/src/container.ts Outdated
@@ -3,9 +3,6 @@
* Licensed under the MIT License.
*/

// eslint-disable-next-line import/no-internal-modules
import merge from "lodash/merge";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@tylerbutler tylerbutler merged commit d414ded into microsoft:main Nov 16, 2023
25 checks passed
@tylerbutler tylerbutler deleted the tsc-multi-dds branch November 16, 2023 23:46
@alexvy86 alexvy86 mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josmithr Josmithr Josmithr approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees
No one assigned
Labels
area: dds Issues related to distributed data structures area: loader Loader related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tylerbutler @msfluid-bot @Josmithr