Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove build files in nested folders #18283

Merged
merged 1 commit into from Nov 13, 2023

Conversation

tylerbutler
Copy link
Member

Updates the clean scripts across the repo to delete nested temporary build files. We need this change to properly clean up fluid-build and tsc-multi output, which can be outside the root of the package.

@github-actions github-actions bot added area: build Build related issues area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Nov 13, 2023
@tylerbutler tylerbutler requested a review from a team November 13, 2023 22:39
@Josmithr
Copy link
Contributor

Josmithr commented Nov 13, 2023

Updates the clean scripts across the repo to delete nested temporary build files. We need this change to properly clean up fluid-build and tsc-multi output, which can be outside the root of the package.

Where do the nested temp files end up? Under src? dist? Can we configure this? Just wondering if we can shove all of it under temp/tsc or something, and simplify our clean scripts a bit.

Later, we could also update api-extractor to dump its temp files under temp/api-extractor or something and really simplify things.

@tylerbutler
Copy link
Member Author

Updates the clean scripts across the repo to delete nested temporary build files. We need this change to properly clean up fluid-build and tsc-multi output, which can be outside the root of the package.

Where do the nested temp files end up? Under src? dist? Can we configure this? Just wondering if we can shove all of it under temp/tsc or something, and simplify our clean scripts a bit.

Later, we could also update api-extractor to dump its temp files under temp/api-extractor or something and really simplify things.

The temp files are created by tsc (which is invoked by tsc-multi) and as far as I can tell they are put relative to the tsconfig, so they wind up in src/test.

@tylerbutler tylerbutler merged commit 131c5ec into microsoft:main Nov 13, 2023
39 checks passed
@tylerbutler tylerbutler deleted the rm-temp-files-glob branch November 13, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants