Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename service-client path to service-clients #18326

Merged
merged 4 commits into from Nov 16, 2023

Conversation

tylerbutler
Copy link
Member

@sonalideshpandemsft @ChumpChief I meant to give this feedback on the original PR, but seems I forgot. Anyway, this PR renames the "service-client" path to "service-clients" which seems to be consistent with our eventual desire to put other clients in that path.

@tylerbutler tylerbutler requested review from msfluid-bot and a team as code owners November 15, 2023 20:49
@github-actions github-actions bot added public api change Changes to a public API base: main PRs targeted against main branch labels Nov 15, 2023
@tylerbutler tylerbutler requested a review from a team as a code owner November 15, 2023 20:57
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 15, 2023
Copy link
Contributor

@sonalideshpandemsft sonalideshpandemsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tylerbutler! : )

@tylerbutler tylerbutler merged commit 9425582 into microsoft:main Nov 16, 2023
25 checks passed
@tylerbutler tylerbutler deleted the service-clients branch November 16, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch dependencies Pull requests that update a dependency file public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants