tree2: Setup Simple layer #18329
Merged
tree2: Setup Simple layer #18329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
|
CLA bugged, Open close to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move simple-tree out of feature libraries.
Also rename SharedTreeObjectFactory to TreeObjectFactory.
See update to ReadMe for changes to the dependency structure.
The idea here is that simple-tree should not be depended on by shared-tree-core (or anything it uses), but instead is a wrapper around the system exposing its simpler types and simpler data model.
This change makes it possible/logical (and cycle free) for a simple-tree to contain the leaf domain, and a specialized schema builder. This opens up a lot more options for how the schema builder can be designed and exposed.
Breaking Changes
Rename SharedTreeObjectFactory to TreeObjectFactory.
Reviewer Guidance
The review process is outlined on this wiki page.
Please evaluate both if this layering change is good, and if it's done correctly.