Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dts-trimming to packages/framework #18353

Merged

Conversation

jikim-msft
Copy link
Contributor

@jikim-msft jikim-msft commented Nov 16, 2023

Description

Related: 18176

This PR adds type-trimming for packages/framework directory. The changes introduced are:

  • Add npm copyfiles package as devDependency
  • Add dtsRollup in api-extractor.json
  • Enable both type-trimming for both ESM & CJS
  • Make fluidBuild to fetch dependencies from the scripts included in dependsOn

@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Nov 16, 2023
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 16, 2023

@fluid-example/bundle-size-tests: +14 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 447.55 KB 447.55 KB +2 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 240.64 KB 240.64 KB No change
loader.js 165.06 KB 165.07 KB +2 Bytes
map.js 48.06 KB 48.06 KB +2 Bytes
matrix.js 141.84 KB 141.85 KB +2 Bytes
odspDriver.js 90.35 KB 90.35 KB +2 Bytes
odspPrefetchSnapshot.js 41.82 KB 41.82 KB +2 Bytes
sharedString.js 162.75 KB 162.75 KB No change
sharedTree2.js 275.1 KB 275.1 KB No change
Total Size 1.73 MB 1.73 MB +14 Bytes

Baseline commit: 42837f4

Generated by 🚫 dangerJS against 17ca0ba

@jikim-msft jikim-msft marked this pull request as ready for review November 16, 2023 23:26
@jikim-msft jikim-msft requested review from msfluid-bot and a team as code owners November 16, 2023 23:26
@jikim-msft jikim-msft requested review from Josmithr and removed request for a team and msfluid-bot November 16, 2023 23:26
@jikim-msft jikim-msft merged commit 13dc16e into microsoft:main Nov 18, 2023
25 checks passed
@jikim-msft jikim-msft deleted the packages-framework/enable-type-trimming branch November 28, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants