Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade puppeteer and related dependencies #19508

Closed
wants to merge 13 commits into from

Conversation

tylerbutler
Copy link
Member

wip

@github-actions github-actions bot added area: dds: propertydds area: examples Changes that focus on our examples dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Feb 6, 2024
@jason-ha

This comment was marked as resolved.

@jason-ha

This comment was marked as resolved.

@jason-ha

This comment was marked as resolved.

@jason-ha
Copy link
Contributor

jason-ha commented Feb 6, 2024

Lingering internal reference?


Refers to: pnpm-lock.yaml:22953 in 53eb47e. [](commit_id = 53eb47e, deletion_comment = False)

@jason-ha

This comment was marked as resolved.

@jason-ha

This comment was marked as resolved.

@jason-ha

This comment was marked as resolved.

@tylerbutler
Copy link
Member Author

  '@fluidframework/datastore-definitions': 2.0.0-internal.8.0.0

Okay with these changes?

Refers to: pnpm-lock.yaml:15730 in 53eb47e. [](commit_id = 53eb47e, deletion_comment = False)

Tough to see what you're referring to in the GitHub UI, but I do expect some internal8.0.0 entries in the lockfile since that's what the typetest "previous version" is right now.

@tylerbutler
Copy link
Member Author

  '@fluidframework/datastore-definitions': 2.0.0-internal.8.0.0

Installed codeflow so I could see what you were referring to. I don't know how to keep pnpm from doing this. I can manually change them back to 8.0.0, but I don't know why pnpm changed themn in the first place.


In reply to: 1930739069


Refers to: pnpm-lock.yaml:15730 in 53eb47e. [](commit_id = 53eb47e, deletion_comment = False)

@tylerbutler
Copy link
Member Author

Do you mean running pnpm dedupe or something else? pnpm dedupe produces a lot of churn.


In reply to: 1930753177


Refers to: pnpm-lock.yaml:28902 in 53eb47e. [](commit_id = 53eb47e, deletion_comment = False)

@jason-ha
Copy link
Contributor

jason-ha commented Feb 7, 2024

  '@fluidframework/datastore-definitions': 2.0.0-internal.8.0.0

Installed codeflow so I could see what you were referring to. I don't know how to keep pnpm from doing this. I can manually change them back to 8.0.0, but I don't know why pnpm changed themn in the first place.

In reply to: 1930739069

Refers to: pnpm-lock.yaml:15730 in 53eb47e. [](commit_id = 53eb47e, deletion_comment = False)

Sorry, I thought the UI would be okay so long as I stuck to whole lines. I guess it can only be a single line.
I wanted to reference multiple lines in places.
The is a lot of duplication and maybe also inconsistent references to some packages like there are three versions of @fluidframework/core-interfaces.

@tylerbutler
Copy link
Member Author

Regarding the lockfile changes, I reset the lockfile to main, nuked node-modules, and ran pnpm i again. Is there something else I should do to minimize lockfile churn?

@jason-ha
Copy link
Contributor

jason-ha commented Feb 7, 2024

Do you mean running pnpm dedupe or something else? pnpm dedupe produces a lot of churn.

In reply to: 1930753177

Refers to: pnpm-lock.yaml:28902 in 53eb47e. [](commit_id = 53eb47e, deletion_comment = False)

If there was going to be a full dedupe, my experience is that it should be done apart from any other change. You just can't figure out what is going on with dedupe and other changes at the same time unless dedupe is done with every dep change.
So I meant less aggressive which is perhaps manual.

@jason-ha
Copy link
Contributor

jason-ha commented Feb 7, 2024

Regarding the lockfile changes, I reset the lockfile to main, nuked node-modules, and ran pnpm i again. Is there something else I should do to minimize lockfile churn?

You shouldn't need to nuke node_modules. But if you do, then you should use pnpm i --frozen-lockfile. If you ran without frozen and got no changes cool. If you got changes that you like, then perhaps we submit those; so we can tease things apart. I just wouldn't expect and fluidframework references to change in this PR.

Copy link
Contributor

@jason-ha jason-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two things. Remove examples/utils/bundle-size-tests @types/puppeteer reference and if possible the "puppeteer" in tsconfig "types" lines.

examples/apps/attributable-map/tsconfig.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: propertydds area: examples Changes that focus on our examples base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants