New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Upgrade puppeteer and related dependencies #19508
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Tough to see what you're referring to in the GitHub UI, but I do expect some internal8.0.0 entries in the lockfile since that's what the typetest "previous version" is right now. |
Installed codeflow so I could see what you were referring to. I don't know how to keep pnpm from doing this. I can manually change them back to 8.0.0, but I don't know why pnpm changed themn in the first place. In reply to: 1930739069 Refers to: pnpm-lock.yaml:15730 in 53eb47e. [](commit_id = 53eb47e, deletion_comment = False) |
|
Do you mean running pnpm dedupe or something else? pnpm dedupe produces a lot of churn. In reply to: 1930753177 Refers to: pnpm-lock.yaml:28902 in 53eb47e. [](commit_id = 53eb47e, deletion_comment = False) |
Sorry, I thought the UI would be okay so long as I stuck to whole lines. I guess it can only be a single line. |
|
Regarding the lockfile changes, I reset the lockfile to main, nuked node-modules, and ran |
If there was going to be a full dedupe, my experience is that it should be done apart from any other change. You just can't figure out what is going on with dedupe and other changes at the same time unless dedupe is done with every dep change. |
You shouldn't need to nuke node_modules. But if you do, then you should use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see two things. Remove examples/utils/bundle-size-tests @types/puppeteer reference and if possible the "puppeteer" in tsconfig "types" lines.
wip