Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2int/7.4] GC: Follow-up changes to support successful roll-out of GC Sweep #19598

Merged
merged 2 commits into from Feb 12, 2024
Merged

[v2int/7.4] GC: Follow-up changes to support successful roll-out of GC Sweep #19598

merged 2 commits into from Feb 12, 2024

Conversation

markfields
Copy link
Member

@markfields markfields commented Feb 12, 2024 •
edited

Description

This PR brings over some GC fixes and minor features requested by a 1P partner who is preparing to ship GC Sweep:

  • Some telemetry fixes that will help us to monitor the accuracy and impact of GC better
  • A new option to allow enabling sleep only for attachment blobs at first

Porting the following commits to the release/v2int/7.4 branch to be released in internal.7.4.7:

Related port PRs for other releases:

Reviewer Guidance

FYI no merge conflicts when cherry-picking these 2 commits (one Navin had previously merged to this branch, the other I had merged to the release/v2int/8.0 branch)

agarwal-navin and others added 2 commits February 12, 2024 18:41
@agarwal-navin @markfields
[Port v2int 7.4] Follow up changes to GC sweep op that are needed to …
ca35d12 
…enable sweep (microsoft#19204)

This PR ports the following changes to internal-7.4 branch. internal-7.4
contains changes that will help enable sweep and these are follow ups
that did not make it to the branch.
- [Initialize GC state as soon as possible and update it on
(re)connecti… · microsoft/FluidFramework@40ad2d4
(github.com)](microsoft@40ad2d4)
- [GC: Fix GC deleted stats not correctly updated for data stores by
agarwal-navin · Pull Request microsoft#18890 · microsoft/FluidFramework
(github.com)](microsoft#18890)
- [GC: Added whether tombstone is enabled to GarbageCollection_end event
by agarwal-navin · Pull Request microsoft#18927 · microsoft/FluidFramework
(github.com)](https://github.com/microsoft/FluidFramework/pull/18927/files)
@markfields
[v2int/8.0] GC: Add option to run Sweep only for Attachment Blobs (mi…
a86485d 
…crosoft#19591)

Porting 15bce65 and
f46c5dc to
`release/client/2.0.0-rc.1.0.0`.

Related port PRs:
* microsoft#19589
@markfields markfields requested review from a team as code owners February 12, 2024 19:02
@github-actions github-actions bot added area: build Build related issues area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file public api change Changes to a public API base: main PRs targeted against main branch labels Feb 12, 2024
@markfields markfields changed the base branch from main to release/v2int/7.4 February 12, 2024 19:04
@markfields markfields requested review from a team as code owners February 12, 2024 19:04
markfields
markfields commented Feb 12, 2024
View reviewed changes
Copy link
Member Author

@markfields markfields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the diff myself just now, looks as expected

@Abe27342 Abe27342 removed request for a team February 12, 2024 19:20
@msfluid-bot
Copy link
Collaborator

Could not find a usable baseline build with search starting at CI a2544ce

Generated by 🚫 dangerJS against a86485d

@markfields markfields merged commit dd12f2e into microsoft:release/v2int/7.4 Feb 12, 2024
23 checks passed
@markfields markfields deleted the v2int/7.4/gc-sweep branch February 12, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyler-cai-microsoft tyler-cai-microsoft tyler-cai-microsoft approved these changes

@rajatch-ff rajatch-ff Awaiting requested review from rajatch-ff

Assignees
No one assigned
Labels
area: build Build related issues area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markfields @msfluid-bot @tyler-cai-microsoft @agarwal-navin