Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove ITelemetryProperties and replace with equivalent ITelemetryBaseProperties #19750

Closed
wants to merge 1 commit into from
Closed

refactor: Remove ITelemetryProperties and replace with equivalent ITelemetryBaseProperties #19750

wants to merge 1 commit into from

Conversation

alexvy86
Copy link
Contributor

Description

Removes the deprecated ITelemetryProperties and replaces its internal uses with the equivalent ITelemetryBaseProperties.

Breaking changes

The ITelemetryProperties export is removed from @fluidframework/core-interfaces.

Reviewer Guidance

The review process is outlined on this wiki page.

@alexvy86 alexvy86 requested a review from a team as a code owner February 22, 2024 15:47
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: driver Driver related issues area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues public api change Changes to a public API base: main PRs targeted against main branch labels Feb 22, 2024
@alexvy86 alexvy86 requested review from markfields and a team February 22, 2024 15:47
@msfluid-bot
Copy link
Collaborator

Baseline CI build failed, cannot generate bundle analysis at this time

Baseline commit: ed1c286

Generated by 🚫 dangerJS against d5e4121

@alexvy86
Copy link
Contributor Author

Closing in favor of #19752 that includes these changes.

@alexvy86 alexvy86 closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markfields markfields Awaiting requested review from markfields

Assignees
No one assigned
Labels
area: dds: tree area: dds Issues related to distributed data structures area: driver Driver related issues area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexvy86 @msfluid-bot