Add ability to provide exception handler for timer's callback #20745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: loader
⯅ @fluid-example/bundle-size-tests: +468 Bytes
Baseline commit: efb82f8 |
pragya91
reviewed
Apr 19, 2024
| @@ -138,7 +138,7 @@ export function setLongTimeout(timeoutFn: () => void, timeoutMs: number, setTime | |||
|
|
|||
| // @internal | |||
| export class Timer implements ITimer { | |||
| constructor(defaultTimeout: number, defaultHandler: () => void, getCurrentTick?: () => number); | |||
| constructor(defaultTimeout: number, defaultHandler: () => void, exceptionHandler?: ((error: unknown) => void) | undefined); | |||
There was a problem hiding this comment.
If we specified the type of error here as any, then we could keep the other error types preserved which you had to change below to unknown.
There was a problem hiding this comment.
I'm not sure what you mean. unknown is safer than any, as any could be implicitly casted by compiler to any type, so it's easy to introduce a bug without noticing it.
The only casts I see is in UT and they are unrelated to this handler - they are there because compiler does not understand that clock.tick() has side-effects, so it thinks that exceptionCounter is always one (after first assert).
pragya91
approved these changes
Apr 23, 2024
vladsud
added a commit
that referenced
this pull request
Apr 25, 2024
… using "read" connection. (#20817) First step to enable Audience to have same behavior for "read" and "write" clients - "connected" event raised when "self" is present in Audience. Next step: - client is caught up with latest ops. For deeper description of work in this space, please see first PR below. This is continuation of this work: - #20703 - #20752 - #20704 - #20745 - #20766 And active PRs (do not block this PR, but make whole story more consistent for serialized / rehydrated containers): - #20768 - #20767 Changeset added in previous PR in the same version (part of it should have been included in this PR, but made it earlier by accident): [.changeset/cruel-trees-dance.md](https://github.com/microsoft/FluidFramework/pull/20215/files#diff-8f706b3e769f698985bea8fbf9bb3fb0a0a8798de53ad3f51cbace1dd3d1d2b2)
vladsud
added a commit
that referenced
this pull request
Apr 26, 2024
…d" event when using "read" connections. (#20854) Enable Audience to have same behavior for "read" and "write" clients: - "connected" event raised when we caught up on ops. For deeper description of work in this space, please see first PR below. This is continuation of this work: - #20703 - #20752 - #20704 - #20745 - #20766 - #20817 And active PRs (do not block this PR, but make whole story more consistent for serialized / rehydrated containers): - #20767 Changeset added in previous PR in the same version (part of it should have been included in this PR, but made it earlier by accident): [.changeset/cruel-trees-dance.md](https://github.com/microsoft/FluidFramework/pull/20215/files#diff-8f706b3e769f698985bea8fbf9bb3fb0a0a8798de53ad3f51cbace1dd3d1d2b2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to add here...