Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main > Release/Client/rc3]: Use tenant domain instead of siteUrl in /shares api in ODSP driver (#20738) #20769

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Apr 21, 2024

Description

Task Link

To load a Fluid container, host/app provides a URL which is used to talk to service to load the container. That URL can be a share link which host/app specifies explicitly to Fluid that the URL is a share link. Fluid then uses that link to fetch the snapshot for the container. User sometimes don’t have permissions initially, so to save COGS, Fluid supply this share link in body of trees latest call to the service, so that in 1 network call, we can do the redeem and also fetch the snapshot. Sometimes this redeem on service side fails (in case it is first time sharing with that user), then the service throws on the trees latest call. Fluid catches this exception and determines/guess if this is because of redeem failure at service side and then fallback to doing redeem by itself using the /shares API. Once the redeem fails even in /shares API, the container load fails.

In this issue, for outlook Win32 the /shares API (Documentation link for API:
Link) call is failing because of the length limitation on the API. There are 2 ways to call the /shares API(for Fluid use),

Method 1: site-url/_api/v2.0/shares/{shareID}
This has length limitation of about 400 characters.

Method 2: tenant-domain/_api/v2.0/shares/{shareID} Then the length limitation is about 2048 characters. where this, share ID is generated by encoding the share link supplied by the app in the above load request. So, encoding longer URL will give longer shareID.

Tenant-domain can be extracted from site-url by doing: Const tenant-domain = new URL(site-url).origin

This issue occurred for Outlook win 32, because MDO team started adding some, additional long query params to the share link. So, we are switching to use Method 1 instead of Method 2.

…icrosoft#20738)

## Description

[Task
Link](https://dev.azure.com/fluidframework/internal/_workitems/edit/7650)

To load a Fluid container, host/app provides a URL which is used to talk
to service to load the container. That URL can be a share link which
host/app specifies explicitly to Fluid that the URL is a share link.
Fluid then uses that link to fetch the snapshot for the container. User
sometimes don’t have permissions initially, so to save COGS, Fluid
supply this share link in body of trees latest call to the service, so
that in 1 network call, we can do the redeem and also fetch the
snapshot. Sometimes this redeem on service side fails (in case it is
first time sharing with that user), then the service throws on the trees
latest call. Fluid catches this exception and determines/guess if this
is because of redeem failure at service side and then fallback to doing
redeem by itself using the /shares API. Once the redeem fails even in
/shares API, the container load fails.

In this issue, for outlook Win32 the /shares API (Documentation link for
API:
[Link](https://docs.microsoft.com/en-us/onedrive/developer/rest-api/api/shares_get))
call is failing because of the length limitation on the API. There are 2
ways to call the /shares API(for Fluid use),

Method 1: site-url/_api/v2.0/shares/{shareID}
This has length limitation of about 400 characters.

Method 2: tenant-domain/_api/v2.0/shares/{shareID}
Then the length limitation is about 2048 characters.
where this, share ID is generated by encoding the share link supplied by
the app in the above load request. So, encoding longer URL will give
longer shareID.

Tenant-domain can be extracted from site-url by doing:
Const tenant-domain = new URL(site-url).origin

This issue occurred for Outlook win 32, because MDO team started adding
some, additional long query params to the share link.
So, we are switching to use Method 1 instead of Method 2.

---------

Co-authored-by: Jatin Garg <jatingarg@Jatins-MacBook-Pro-2.local>
Co-authored-by: Navin Agarwal <45832642+agarwal-navin@users.noreply.github.com>
@jatgarg jatgarg self-assigned this Apr 21, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +1.39 KB
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 452.29 KB 452.29 KB No change
azureClient.js 545.36 KB 545.36 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 255.17 KB 255.17 KB No change
fluidFramework.js 339.39 KB 339.39 KB No change
loader.js 129.89 KB 129.89 KB No change
map.js 41.35 KB 41.35 KB No change
matrix.js 143.62 KB 143.62 KB No change
odspClient.js 513.36 KB 513.82 KB +477 Bytes
odspDriver.js 97.06 KB 97.52 KB +477 Bytes
odspPrefetchSnapshot.js 41.93 KB 42.39 KB +470 Bytes
sharedString.js 161.39 KB 161.39 KB No change
sharedTree.js 339.39 KB 339.39 KB No change
Total Size 3.14 MB 3.14 MB +1.39 KB

Baseline commit: 33d709a

Generated by 🚫 dangerJS against d214092

@jatgarg jatgarg merged commit 75a9de2 into microsoft:release/client/2.0.0-rc.3.0 Apr 22, 2024
28 of 29 checks passed
@jatgarg jatgarg deleted the rc3sh branch April 23, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants