Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup some infrastructure for the repository. #100

Merged
merged 5 commits into from Jun 1, 2019

Conversation

Projects
None yet
2 participants
@tannergooding
Copy link
Member

commented Jun 1, 2019

This is the same infrastructure setup that was done for ClangSharp in microsoft/ClangSharp#60, but it additionally removes the now unneeded custom libLLVM support.

@tannergooding

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

This also removes the now outdated/checked in copy of ClangSharpPInvokeGenerator (which is the bulk of the diff).

@mjsabby

mjsabby approved these changes Jun 1, 2019

@tannergooding

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

Seems I broke travis, will investigate shortly.

@tannergooding tannergooding force-pushed the tannergooding:cleanup branch from a838546 to 0d7c24b Jun 1, 2019

@tannergooding

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

Got most things resolved (namely forgetting to mark shell scripts as executable), but libLLVM still can't be found when running tests. It's passing locally on a clean machine (both Windows and Linux), so I'm still trying things out...

@tannergooding

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

It might be because the CI is running on "trusty" and I upgraded the PackageReference from 5.0.1 to 7.0.1...

@tannergooding tannergooding force-pushed the tannergooding:cleanup branch 3 times, most recently from d2cd707 to 4382a26 Jun 1, 2019

@tannergooding

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

Ok. Some dependency of libLLVM 7.0.1 is missing from the Travis CI machines. I tested up to bionic, and they all failed.

That, unfortunately, means that the CI tests are validating much older LLVM bits.

@tannergooding tannergooding force-pushed the tannergooding:cleanup branch from 4382a26 to 2e14bd4 Jun 1, 2019

@tannergooding

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

I've squashed the additional changes into a single commit to make reviewing them easier. I've also attempted to keep LLVMSharp targeting 7.0.1 (so the nuget package is more correct) while keeping LLVMSharp.UnitTests targeting 5.0.1 (so tests in CI can pass).

@mjsabby

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

Thanks. We should talk offline about dnceng vs getting our own instance. And then retiring this Travis CI system.

@mjsabby

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

By talk I mean ... nudging the relevant folks more :)

@tannergooding tannergooding merged commit 19a14a7 into microsoft:master Jun 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@tannergooding tannergooding deleted the tannergooding:cleanup branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.