From a0a117aab8687ca3dffa98e4de790b4ce21599ab Mon Sep 17 00:00:00 2001 From: Nikita Titov Date: Thu, 26 Sep 2019 07:09:31 +0300 Subject: [PATCH] [python] make dump_text() private (#2434) * make dump_text() private * updated test --- python-package/lightgbm/basic.py | 2 +- tests/python_package_test/test_basic.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/python-package/lightgbm/basic.py b/python-package/lightgbm/basic.py index e7762f35ff4..e3c5c84d8ca 100644 --- a/python-package/lightgbm/basic.py +++ b/python-package/lightgbm/basic.py @@ -1588,7 +1588,7 @@ def add_features_from(self, other): _safe_call(_LIB.LGBM_DatasetAddFeaturesFrom(self.handle, other.handle)) return self - def dump_text(self, filename): + def _dump_text(self, filename): """Save Dataset to a text file. This format cannot be loaded back in by LightGBM, but is useful for debugging purposes. diff --git a/tests/python_package_test/test_basic.py b/tests/python_package_test/test_basic.py index 5d6509f5d3b..ea40e98d65c 100644 --- a/tests/python_package_test/test_basic.py +++ b/tests/python_package_test/test_basic.py @@ -127,11 +127,11 @@ def test_add_features_equal_data_on_alternating_used_unused(self): d1.add_features_from(d2) with tempfile.NamedTemporaryFile() as f: d1name = f.name - d1.dump_text(d1name) + d1._dump_text(d1name) d = lgb.Dataset(X, feature_name=names).construct() with tempfile.NamedTemporaryFile() as f: dname = f.name - d.dump_text(dname) + d._dump_text(dname) with open(d1name, 'rt') as d1f: d1txt = d1f.read() with open(dname, 'rt') as df: