From bd8695eca2cf1778befc56e94911cd713a987ef1 Mon Sep 17 00:00:00 2001 From: Ilya Matiach Date: Sun, 26 Aug 2018 21:19:48 -0400 Subject: [PATCH] updating based on comments --- CMakeLists.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 3323e57e91d4..30addd276094 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -179,9 +179,11 @@ if(USE_SWIG) set_property(SOURCE swig/lightgbmlib.i PROPERTY SWIG_FLAGS "${swig_options}") swig_add_module(_lightgbm_swig java swig/lightgbmlib.i) swig_link_libraries(_lightgbm_swig _lightgbm) + # needed to ensure linux build does not have lib specified twice, eg liblib_lightgbm_swig + set_target_properties(_lightgbm_swig PROPERTIES PREFIX "") + # needed in latest version of cmake for VS and MINGW builds to ensure output dll has lib prefix + set_target_properties(_lightgbm_swig PROPERTIES OUTPUT_NAME "lib_lightgbm_swig") if(WIN32) - # needed in latest version of cmake for VS and MINGW builds to ensure output dll has lib prefix - set_target_properties(_lightgbm_swig PROPERTIES OUTPUT_NAME "lib_lightgbm_swig") if(MINGW OR CYGWIN) add_custom_command(TARGET _lightgbm_swig POST_BUILD COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java