From e09e4caa4ded45a074e05ab247e8a4f11ed12644 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Sun, 12 May 2019 03:36:27 -0500 Subject: [PATCH] fixed minor issues with R package (#2167) --- CMakeLists.txt | 2 +- R-package/demo/categorical_features_prepare.R | 2 +- R-package/src/R_init.c | 12 ------------ R-package/src/R_init.h | 7 ------- 4 files changed, 2 insertions(+), 21 deletions(-) delete mode 100644 R-package/src/R_init.c delete mode 100644 R-package/src/R_init.h diff --git a/CMakeLists.txt b/CMakeLists.txt index cdad4644ed5..878256463a6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -11,7 +11,7 @@ OPTION(USE_OPENMP "Enable OpenMP" ON) OPTION(USE_GPU "Enable GPU-accelerated training" OFF) OPTION(USE_SWIG "Enable SWIG to generate Java API" OFF) OPTION(USE_HDFS "Enable HDFS support (EXPERIMENTAL)" OFF) -OPTION(USE_R35 "Set to ON if your R version is not smaller than 3.5" OFF) +OPTION(USE_R35 "Set to ON if your R version is not earlier than 3.5" OFF) if(APPLE) OPTION(APPLE_OUTPUT_DYLIB "Output dylib shared library" OFF) diff --git a/R-package/demo/categorical_features_prepare.R b/R-package/demo/categorical_features_prepare.R index d92e5b1dc96..69936913d3a 100644 --- a/R-package/demo/categorical_features_prepare.R +++ b/R-package/demo/categorical_features_prepare.R @@ -31,7 +31,7 @@ str(bank) # For this task, we use lgb.prepare # The function transforms the data into a fittable data # -# Classes ‘data.table’ and 'data.frame': 4521 obs. of 17 variables: +# Classes 'data.table' and 'data.frame': 4521 obs. of 17 variables: # $ age : int 30 33 35 30 59 35 36 39 41 43 ... # $ job : num 11 8 5 5 2 5 7 10 3 8 ... # $ marital : num 2 2 3 2 2 3 2 2 2 2 ... diff --git a/R-package/src/R_init.c b/R-package/src/R_init.c deleted file mode 100644 index 7e263498407..00000000000 --- a/R-package/src/R_init.c +++ /dev/null @@ -1,12 +0,0 @@ - -// Register Dynamic Symbols - -#include -#include -#include -#include "R_init.h" - -void R_init_lightgbm(DllInfo* info) { - R_registerRoutines(info, NULL, NULL, NULL, NULL); - R_useDynamicSymbols(info, TRUE); -} diff --git a/R-package/src/R_init.h b/R-package/src/R_init.h deleted file mode 100644 index 015b12db170..00000000000 --- a/R-package/src/R_init.h +++ /dev/null @@ -1,7 +0,0 @@ -// Register Dynamic Symbols -#ifndef R_INIT_LIGHTGBM_H -#define R_INIT_LIGHTGBM_H - -void R_init_lightgbm(DllInfo* info); - -#endif // R_INIT_LIGHTGBM_H