Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "download" badge #2224

Merged
merged 6 commits into from Jun 17, 2019
Merged

add "download" badge #2224

merged 6 commits into from Jun 17, 2019

Conversation

guolinke
Copy link
Collaborator

No description provided.

README.md Outdated
@@ -7,6 +7,7 @@ LightGBM, Light Gradient Boosting Machine
[![Documentation Status](https://readthedocs.org/projects/lightgbm/badge/?version=latest)](https://lightgbm.readthedocs.io/)
[![GitHub Issues](https://img.shields.io/github/issues/Microsoft/LightGBM.svg)](https://github.com/microsoft/LightGBM/issues)
[![License](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/microsoft/LightGBM/blob/master/LICENSE)
[![Downloads](https://pepy.tech/badge/lightgbm)](https://pepy.tech/project/lightgbm)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a little bit confusing to have Downloads badge in general README because it's not clear what these "downloads" mean: GitHub releases, Python-package, R-package, or something else.

UPD: For instance, CRAN badge has the same appearance: https://cranlogs.r-pkg.org/badges/grand-total/devtools?color=blue

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. maybe we can try to add number of clones and download of release in main page.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can try to add number of clones and download of release in main page.

Just replaced issue count badge with number of releases downloads. I think issue badge was useless, because one can see number of issues upper at the same page.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number of clones: badges/shields#880.

Copy link
Collaborator Author

@guolinke guolinke Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems the number of release download is very low. I guess most users use pip, or clone then build by themself.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! 33k during more than 2 years...

Maybe JARs will increase downloads count...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to remove the download counts of release.

@StrikerRUS StrikerRUS merged commit 7da11ff into master Jun 17, 2019
@StrikerRUS StrikerRUS deleted the guolinke-patch-1 branch June 17, 2019 11:52
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants