[python] Windows wheels that support GPUs via OpenCL #3403
Conversation
…' into windows-gpu-builds-take-2
…' into windows-gpu-builds-take-3
There was a problem hiding this comment.
Awesome contribution! Thanks a lot guys! Hope that ability to set default device to gpu will come soon.
I'll update docs to notify users about this useful feature that will allow them to simplify GPU version installation later today and will ping you to review if you don't mind.
| # Install OpenCL platform from installer executable expected in workspace cache | ||
|
|
||
| Write-Output "Running OpenCL installer" | ||
| Invoke-Command -ScriptBlock {Start-Process "$cache\$installer" -ArgumentList '/S /V"/quiet /norestart /passive /log opencl.log"' -Wait} |
There was a problem hiding this comment.
Just a question. What does this syntax mean? /V" ... opencl.log". I mean double quotes.
There was a problem hiding this comment.
The installer package has a program inside a program: the outer (extractor) program takes the /S and /V arguments. The value of the /V argument is the list of arguments you want passed to the inner (installer) program. You need to quote them to make sure they're all passed together, not interpreted as (unrecognized) arguments to the outer program. Since the ArgumentList is already single-quoted, you have to use double-quotes for the interior quotes.
No problem. Thanks for all your contributions to this PR. |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This is a follow-up to #3144, to actually use the new infrastructure to build Python wheels that can work both with and without GPUs.