Natvis: strip address prefix from string pointer DisplayStrings"#1573
Merged
Conversation
WardenGnaw
reviewed
Jun 6, 2026
WardenGnaw
force-pushed
the
natvis-sub-specifier-cleanup
branch
from
5d05d41 to
b978182
Compare
…ings GDB and LLDB prefix string pointer results with the pointer address when evaluating ,sub, ,su or ,sb format specifiers. This causes the address to appear inline in the display value. Add StripFormatSpecifier() and ExtractFormatSpecifier() to parse format specifiers from NatVis expressions. Add CleanUtf16StringValue() to strip the address and surrounding u"..." quotes for ,sub / ,su, and CleanAsciiStringValue() to strip the address for ,sb. Call each in FormatValue for the corresponding specifier. All new functions include unit tests.
…iStringValue
Remove StripFormatSpecifier and its tests: the method is dead code.
Format specifiers are already handled by ProcessFormatSpecifiers in
VariableInformation, which transforms them into valid C++ casts before
evaluation by GDB/LLDB.
Fix CleanAsciiStringValue to also strip the surrounding "..." quotes,
matching CleanUtf16StringValue's behaviour. VS evaluates {ptr,sb} to
bare text without quotes; leaving the GDB/LLDB-returned quotes in place
caused QByteArray to display as ""Hello World!"" instead of "Hello World!".
WardenGnaw
force-pushed
the
natvis-sub-specifier-cleanup
branch
from
74e185f to
5233b25
Compare
WardenGnaw
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GDB and LLDB prefix string pointer results with the pointer address when evaluating ,sub, ,su or ,sb format specifiers. This causes the address to appear inline in the display value.
Add StripFormatSpecifier() and ExtractFormatSpecifier() to parse format specifiers from NatVis expressions. Add CleanUtf16StringValue() to strip the address and surrounding u"..." quotes for ,sub / ,su, and CleanAsciiStringValue() to strip the address for ,sb. Call each in FormatValue for the corresponding specifier. All new functions include unit tests.