Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added elu emit function to keras2_emitter and caffe_emitter #544

Merged
merged 6 commits into from Jun 11, 2019

Conversation

Projects
None yet
4 participants
@BlaiseRitchie
Copy link
Contributor

commented Jan 4, 2019

Added elu emit function to keras2_emitter to fix "KerasEmitter has not supported operator [Elu]." error

@msftclas

This comment has been minimized.

Copy link

commented Jan 4, 2019

CLA assistant check
All CLA requirements met.

@BlaiseRitchie BlaiseRitchie changed the title Added elu emit function to keras2_emitter Added elu emit function to keras2_emitter and caffe_emitter Jan 4, 2019

@rainLiuplus

This comment has been minimized.

Copy link
Collaborator

commented Jan 5, 2019

Hi @BlaiseRitchie , thanks for your contribution! Have you tested the accuracy of the conversion results? We have implemented some testing tools and could you please add some scripts to test your code? You can do it by the following steps:

  1. Add test model's config into corresponding parser's architecture_map like this.

  2. Edit test_table. Add the model name and emitter into corresponding item like this:
    your_model_name' : [CaffeEmit, KerasEmit].

  3. Run the corresponding test_xxx.py like test_tensorflow.py. Finally it will output test result as:

  error: 8.642673492431641e-07 
  L1 error: 1.3829053e-06
  SNR: 34.28389626117947
  PSNR: 63.29787522393757
Show resolved Hide resolved tests/test_caffe.py Outdated
Show resolved Hide resolved tests/test_keras.py Outdated

@BlaiseRitchie BlaiseRitchie force-pushed the BlaiseRitchie:patch-1 branch 2 times, most recently from 21e48c9 to 169dab5 Jan 9, 2019

BlaiseRitchie and others added some commits Jan 4, 2019

Added elu emit function to keras2_emitter
Added elu emit function to keras2_emitter to fix "KerasEmitter has not supported operator [Elu]." error
Add Elu to caffe emitter
Add Elu to caffe emitter
Blaise Ritchie

@BlaiseRitchie BlaiseRitchie force-pushed the BlaiseRitchie:patch-1 branch from 169dab5 to a95616d Jan 9, 2019

@linmajia linmajia requested a review from rainLiuplus Jan 13, 2019

Yu Liu (FA Talent) and others added some commits Jun 10, 2019

Yu Liu (FA Talent)

@rainLiuplus rainLiuplus merged commit d7e40c4 into microsoft:master Jun 11, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.