Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables multiple outputs for conversion to tensorflow #766

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@SmokerX
Copy link
Contributor

SmokerX commented Nov 5, 2019

@SmokerX

This comment has been minimized.

Copy link
Contributor Author

SmokerX commented Nov 5, 2019

@rainLiuplus
I am sorry that this PR did not pass the automatic test, but I looked at the test case that was not passed, and it is related to keras and mxnet, but my modification is only related to tensorflow, and it is the last step of the conversion process, based on the py generating tensorflow. Processing after the file.
I would like to ask you to see if there is a problem with this test case.

@rainLiuplus

This comment has been minimized.

Copy link
Collaborator

rainLiuplus commented Nov 5, 2019

Hi @SmokerX, thanks for your contributions!
The test cases you mentioned have been restarted. They are often out of memory and out of time due to the limitations of Travis platform.

@SmokerX

This comment has been minimized.

Copy link
Contributor Author

SmokerX commented Nov 5, 2019

@rainLiuplus
I notice that this automatic has finished 14 minutes ago, but you said those test cases had been restarted 34 minutes ago. The status of automatic test is finished now. Did they really restart?

@rainLiuplus

This comment has been minimized.

Copy link
Collaborator

rainLiuplus commented Nov 5, 2019

@SmokerX, sorry, I do not understand your meaning. I manually restarted the test cases.

@SmokerX

This comment has been minimized.

Copy link
Contributor Author

SmokerX commented Nov 5, 2019

@rainLiuplus
OK, these test cases are running now.

@SmokerX

This comment has been minimized.

Copy link
Contributor Author

SmokerX commented Nov 5, 2019

@rainLiuplus
It seems to be out of memory again...

@SmokerX

This comment has been minimized.

Copy link
Contributor Author

SmokerX commented Nov 6, 2019

@rainLiuplus
There are still 2 test cases left this time.

@rainLiuplus

This comment has been minimized.

Copy link
Collaborator

rainLiuplus commented Nov 6, 2019

The tests are all passed now.

@rainLiuplus rainLiuplus merged commit c1c748e into microsoft:master Nov 6, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.