Fix for Bounds Control With Non Uniform Scale Issues #10133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zee2, can you take a look at this PR? |
|
Tested and confirmed it worked old behavior: new behavior: |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
RogPodge
approved these changes
Aug 31, 2021
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
microsoft#8992 Co-authored-by: mal176 <simon.malnar@data61.csiro.au>
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
microsoft#8992 Co-authored-by: mal176 <simon.malnar@data61.csiro.au>
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
microsoft#8992 Co-authored-by: mal176 <simon.malnar@data61.csiro.au>
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
microsoft#8992 Co-authored-by: mal176 <simon.malnar@data61.csiro.au>
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
microsoft#8992 Co-authored-by: mal176 <simon.malnar@data61.csiro.au>
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 8, 2021
microsoft#8992 Co-authored-by: mal176 <simon.malnar@data61.csiro.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
BoundsControl exhibited unexpected behaviour when using NonUniform scaling on a rotated GameObject. This PR fixes that.
Changes
Verification
Open BoundsControlExamples scene. Change the ScaleBehavour under ScaleHandlesConfiguration to NonUniform. Using the scale handles on an arbitrarily rotated GameObject now behaves as expected (opposite corner stays fixed in world space)