Update obj exporter to fix coordinate space, winding order, and culture formatting #10208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unity and OBJ differ in each! Unity is right-handed, OBJ is left-handed. Unity is CW, OBJ is CCW.
This was causing issues due to different cultures' usage of . vs ,
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
MaxWang-MS
approved these changes
Sep 14, 2021
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
Update obj exporter to fix coordinate space, winding order, and culture formatting
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
Update obj exporter to fix coordinate space, winding order, and culture formatting
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
Update obj exporter to fix coordinate space, winding order, and culture formatting
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
Update obj exporter to fix coordinate space, winding order, and culture formatting
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
Update obj exporter to fix coordinate space, winding order, and culture formatting
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 8, 2021
Update obj exporter to fix coordinate space, winding order, and culture formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unity and OBJ differ! Unity is right-handed, OBJ is left-handed. Unity is CW, OBJ is CCW.
Also slightly adjusted the ordering of new lines for consistency.
Changes