Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/zj #10

Merged
merged 9 commits into from Apr 30, 2019

Conversation

Projects
None yet
5 participants
@woailaosang
Copy link
Contributor

commented Apr 29, 2019

fix CPU train --> GPU test, GPU train --> CPU test. But CPU train -->multi-GPU test will report error.
remove ujson,
remove glove from model_zoo/demo/conf.json,
add nltk.download('punkt') for problem.py.

woailaosang and others added some commits Apr 29, 2019

@ljshou
Copy link
Member

left a comment

for tutorial models, they still have dependency on GLOVE right? if that's the case, we need to add instructions to download right?

@woailaosang woailaosang removed the request for review from yangze01 Apr 30, 2019

@ericwtlin
Copy link
Contributor

left a comment

Note that there is still a bug when training on CPU and inference on multi-GPU. Need to fix as soon as possible.

@ljshou ljshou merged commit bc305b6 into master Apr 30, 2019

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.