Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Chinese support #18

Merged
merged 38 commits into from May 8, 2019

Conversation

Projects
None yet
4 participants
@woailaosang
Copy link
Contributor

commented May 6, 2019

No description provided.

woailaosang and others added some commits Apr 29, 2019

@ljshou ljshou added the enhancement label May 6, 2019

@@ -58,6 +58,7 @@ def load_from_file(self, conf_path):
raise ConfigurationError("%s is not a legal JSON file, please check your JSON format!" % conf_path)

self.tool_version = self.get_item(['tool_version'])
self.language = self.get_item(['language'], default='english').lower()

This comment has been minimized.

Copy link
@adolphk-yk

adolphk-yk May 7, 2019

Contributor

add language supported check like this:
# check problem types SUPPORTED_PROBLEMS = set(ProblemTypes._member_names_) assert self.problem_type in SUPPORTED_PROBLEMS, "Data type %s is not supported now. Supported types: %s" % (self.problem_type, ",".join(SUPPORTED_PROBLEMS))
remember add language support in settings.py

This comment has been minimized.

Copy link
@ljshou

ljshou May 8, 2019

Member

@woailaosang can you please take a look at this?

This comment has been minimized.

Copy link
@woailaosang

woailaosang May 8, 2019

Author Contributor

okay

woailaosang added some commits May 7, 2019

@woailaosang woailaosang requested a review from adolphk-yk May 8, 2019

@ljshou

ljshou approved these changes May 8, 2019

@ljshou ljshou merged commit ef366cd into master May 8, 2019

1 check passed

license/cla All CLA requirements met.
Details

ericwtlin pushed a commit that referenced this pull request May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.