Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Match layer, improve MatchAttention configuration, fix Concat3D bug #39

Merged
merged 3 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@ericwtlin
Copy link
Contributor

commented May 15, 2019

Add match layer for conv2d layer;
improve MatchAttention configuration

Wutao Lin

@ericwtlin ericwtlin changed the title add Match layer, improve MatchAttention configuration add Match layer, improve MatchAttention configuration, fix Concat3D bug May 15, 2019

@@ -19,7 +19,7 @@ def __init__(self, **kwargs):

@DocInherit
def default(self):
pass
self.activation = 'ReLU'

This comment has been minimized.

Copy link
@woailaosang

woailaosang May 15, 2019

Contributor

Need to add annotation for 'activation' argument?

from utils.exceptions import ConfigurationError

class MatchConf(BaseConf):
"""Configuration for MatchAttention layer

This comment has been minimized.

Copy link
@woailaosang

woailaosang May 15, 2019

Contributor

Configuration for Match layer

@ljshou

ljshou approved these changes May 15, 2019

@ljshou ljshou merged commit 8c82e17 into master May 15, 2019

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.