Escape @s in namespaces in OSS-Health Tool #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small refactor to move the escape method to a helper method on the OSSGadget base class so ti can be called from any CLI as needed.
pmalmsten
approved these changes
Jun 28, 2023
|
I wonder if there is a more central place that this transform could be done across all CLI tools? I'm not very familiar with how CLI argument parsing is done for OSSGadget - I wonder if there is any place there where we might be able to model a Package URL as a type of value (along the lines of integer vs string vs bool etc.), and put this transform there, so that any CLI tool that defines a Package URL type input value would get this parsing behavior automatically? |
|
@pmalmsten I think that would be a better approach, but I'm not sure there's an obvious place to put that. It should be particularly possible for anything that takes just a Purl but for any clis that take multiple arguments it becomes more difficult. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor to move the escape method to a helper method on the OSSGadget base class so ti can be called from any CLI as needed.
Fix #418