Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For new debugger, break on system exit exception of 0 #5397

Merged
merged 2 commits into from Jul 8, 2019
Merged

For new debugger, break on system exit exception of 0 #5397

merged 2 commits into from Jul 8, 2019

Conversation

RaymonGulati1
Copy link
Contributor

@RaymonGulati1 RaymonGulati1 commented Jul 1, 2019 •
edited

Fix #4713

@int19h
Copy link
Contributor

int19h commented Jul 1, 2019

@karthiknadig I wonder if VS should switch to debugOptions, given that we will be deprecating the other stuff eventually?

@karthiknadig
Copy link
Member

Yep. it should be fairly easy to switch to debugOptions from the old style options.

@huguesv
Copy link
Contributor

huguesv commented Jul 2, 2019 •
edited

The readme doesn't show it, but the debugOptions equivalent is BreakOnSystemExitZero
https://github.com/microsoft/ptvsd/blob/59ef76317bd8a8c4b0a3b50b5fe21a605eb3c8b0/src/ptvsd/wrapper.py#L372

@RaymonGulati1 RaymonGulati1 changed the title [WIP] For new debugger, break on system exit exception of 0 For new debugger, break on system exit exception of 0 Jul 6, 2019
@RaymonGulati1 RaymonGulati1 merged commit 0df853e into microsoft:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@int19h int19h int19h left review comments

@huguesv huguesv huguesv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sys.exit(0) throws exception in VS 2017 Community with Python 64 bit 3.6
4 participants
@RaymonGulati1 @int19h @karthiknadig @huguesv