Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For new debugger, break on system exit exception of 0 #5397

Merged

Conversation

Projects
None yet
4 participants
@RaymonGulati1
Copy link
Contributor

commented Jul 1, 2019

Fix #4713

@int19h

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

@karthiknadig I wonder if VS should switch to debugOptions, given that we will be deprecating the other stuff eventually?

@karthiknadig

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Yep. it should be fairly easy to switch to debugOptions from the old style options.

@huguesv

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

The readme doesn't show it, but the debugOptions equivalent is BreakOnSystemExitZero
https://github.com/microsoft/ptvsd/blob/59ef76317bd8a8c4b0a3b50b5fe21a605eb3c8b0/src/ptvsd/wrapper.py#L372

@RaymonGulati1 RaymonGulati1 changed the title [WIP] For new debugger, break on system exit exception of 0 For new debugger, break on system exit exception of 0 Jul 6, 2019

@huguesv

huguesv approved these changes Jul 8, 2019

@RaymonGulati1 RaymonGulati1 merged commit 0df853e into microsoft:master Jul 8, 2019

3 checks passed

PTVS-Github-PR-Dev16 #19186.1 succeeded
Details
PTVS-Tests-Dev16 PTVS-Tests-Dev16 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.