Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Thumbnail does not contain the whole SVG image #12288

Open
1 task done
gammeter opened this issue Jul 8, 2021 · 9 comments
Open
1 task done

SVG Thumbnail does not contain the whole SVG image #12288

gammeter opened this issue Jul 8, 2021 · 9 comments
Labels
Cost-Small Small work item - 0-8 hours of work Issue-Bug Something isn't working Priority-2 Bug that is medium priority Product-File Explorer Power Toys that touch explorer like Preview Pane

Comments

@gammeter
Copy link

gammeter commented Jul 8, 2021

Microsoft PowerToys version

0.41.4

Running as admin

  • Yes

Area(s) with issue?

SVG Thumbnail

Steps to reproduce

open a folder containing SVG images

✔️ Expected Behavior

The thumbnail should show the entire SVG image.

❌ Actual Behavior

The thumbnail contains the top left part of the SVG image only.
Example:
image

And these are the full images:
image image

Other Software

No response

@gammeter gammeter added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jul 8, 2021
@dedavis6797 dedavis6797 added Priority-2 Bug that is medium priority Product-File Explorer Power Toys that touch explorer like Preview Pane and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jul 26, 2021
@dedavis6797 dedavis6797 added this to the Stability Release milestone Jul 26, 2021
@dedavis6797 dedavis6797 added this to To do in 0.45 Release via automation Jul 26, 2021
@dedavis6797 dedavis6797 removed this from To do in 0.45 Release Nov 3, 2021
@dedavis6797 dedavis6797 added this to To do in 0.53 Release via automation Nov 3, 2021
@dedavis6797
Copy link
Contributor

Punting this out to v0.53. @jaimecbernardo does this sound reasonable?

@jaimecbernardo
Copy link
Collaborator

@dedavis6797 , Investigating at least should be reasonable.
It's the matter of investigating if the current renderer we are using supports a fix for this.

@RamblingPSTech
Copy link

svg-not-full-image

Certain SVG images do not render fully

@crutkas crutkas removed this from To do in 0.53 Release Jan 25, 2022
@crutkas
Copy link
Member

crutkas commented Jan 25, 2022

hi friends, can we get an SVG to test this against? without it, will be near impossible to debug

@crutkas crutkas added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 25, 2022
@ghost ghost added the Status-No recent activity no activity in the past 5 days when follow up's are needed label Jan 31, 2022
@ghost
Copy link

ghost commented Jan 31, 2022

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

@gammeter
Copy link
Author

@crutkas sorry for my late reply. Here are the two SVG files that were used to in my original post:
SPIClass
Pin-Klassen
Thank you for your effort.

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Status-No recent activity no activity in the past 5 days when follow up's are needed labels Jan 31, 2022
@gammeter
Copy link
Author

@RamblingPSTech I suggest that you post the files that are visible in your animation too.

@crutkas
Copy link
Member

crutkas commented Feb 1, 2022

note to self:

  • rendering without a view box causes it to not render correctly.
  • Could this be an older webview only issue?
  • removing height / width and replacing with viewbox with same XY works. `viewbox="0 0 251 313" in SVG tag.
    • this could be a good workaround if no viewbox is there
    • A viewbox also may be needed here to force perspective to fit inside icon

@crutkas crutkas added Cost-Small Small work item - 0-8 hours of work and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Feb 1, 2022
@crutkas
Copy link
Member

crutkas commented Feb 1, 2022

#15764 could either solve this or the injecting of viewbox may still be needed. I honestly think we'll need the viewbox to frame size correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cost-Small Small work item - 0-8 hours of work Issue-Bug Something isn't working Priority-2 Bug that is medium priority Product-File Explorer Power Toys that touch explorer like Preview Pane
Projects
None yet
Development

No branches or pull requests

5 participants