Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit KBM test methods: unrelated change caused failure #14596

Open
1 task
crutkas opened this issue Nov 23, 2021 · 1 comment
Open
1 task

Revisit KBM test methods: unrelated change caused failure #14596

crutkas opened this issue Nov 23, 2021 · 1 comment
Labels
Area-Tests issues that relate to tests Issue-Bug Something isn't working Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager

Comments

@crutkas
Copy link
Member

crutkas commented Nov 23, 2021

Microsoft PowerToys version

0.51

Running as admin

  • Yes

Area(s) with issue?

Keyboard Manager

Steps to reproduce

From #14591, a change causes these to start throwing ShortcutErrorType::ShortcutCannotHaveRepeatedModifier from BufferValidationHelpers.cpp but with the change of just going from double modifier to triple modifier.

The change should not have caused this ripple effect.

ValidateShortcutBufferElement_ShouldReturnShortcutMaxShortcutSizeOneActionKeyErrorAndNoAction_OnSettingLastDropDownToRepeatedModifierKeyOnAColumnIfThereAre3OrMoreDropDowns
ValidateShortcutBufferElement_ShouldReturnShortcutMaxShortcutSizeOneActionKeyErrorAndNoAction_OnSettingLastDropDownToNonRepeatedModifierKeyOnAColumnIfThereAre3OrMoreDropDowns

✔️ Expected Behavior

test should have chances are failed but not with that failure

❌ Actual Behavior

failed with duplicate key error

Other Software

No response
@crutkas crutkas added Issue-Bug Something isn't working Area-Tests issues that relate to tests labels Nov 23, 2021
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Nov 23, 2021
@crutkas crutkas changed the title Revisit KBM test methods: unrelated change caused falure Revisit KBM test methods: unrelated change caused failure Nov 23, 2021
@Jay-o-Way Jay-o-Way added the Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager label Nov 23, 2021
@jaimecbernardo
Copy link
Collaborator

Looking at the testes, they do seem to have duplicate VK_CONTROL in the same line, so they now throw that error instead of ShortcutMaxShortcutSizeOneActionKey.

@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Tests issues that relate to tests Issue-Bug Something isn't working Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crutkas @jaimecbernardo @Jay-o-Way