Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancy Zones new editor needs to support multiple monitors #195

Closed
enricogior opened this issue Sep 5, 2019 · 18 comments · Fixed by #391
Assignees

Comments

@enricogior
Copy link
Collaborator

@enricogior enricogior commented Sep 5, 2019

Summary of the new feature/enhancement

Currently the new FZ editor only comes up and applies zone layouts to the primary monitor. In order to get a layout on a different monitor, the original custom editor is needed. Bret and Jeff have a design for this change and now they need to implement it.

Proposed technical implementation details (optional)

Note that when this is done the original editor should be removed as well as the setting to toggle between editors.

@corbob

This comment has been minimized.

Copy link
Contributor

@corbob corbob commented Sep 5, 2019

I'll leave this note for anyone like me that was confused.

  • First you turn off this setting: Use new zone editing experience (Preview)
  • Then you ignore this button and read the text above it:
    Zone configuration heading with Edit Zones button
  • Follow the text instructions and press Win + ~
  • ???
  • Profit!
@0xabu

This comment has been minimized.

Copy link

@0xabu 0xabu commented Sep 5, 2019

In addition to the comment above, clues for the ??? step are to be found in ZoneWindow.cpp. You need to press 'e' before you can do much else.

@TheMrJukes

This comment has been minimized.

Copy link
Collaborator

@TheMrJukes TheMrJukes commented Sep 5, 2019

Yeah, we didn't really document usage of the old editor since we will be cutting it once the new editor completely supports multimon. The old implementation is a bit tedious.
Also, the "Edit zones" button only invoking the new editor is a bug. It should invoke whichever editor you have chosen to use.

@WeirdScience06

This comment has been minimized.

Copy link

@WeirdScience06 WeirdScience06 commented Sep 6, 2019

On a non US keyboard, I cannot launch configuration with the WIN + ~ shortcut

@rabenimmermehr

This comment has been minimized.

Copy link

@rabenimmermehr rabenimmermehr commented Sep 6, 2019

On a non US keyboard, I cannot launch configuration with the WIN + ~ shortcut

@WeirdScience06 See this issue: #203
In the comments they're discussing different keys for different keyboard-layouts

@dzsquared

This comment has been minimized.

Copy link

@dzsquared dzsquared commented Sep 6, 2019

Another work around is to change your "main monitor" setting, set the fancy zones in the new editor, change the main monitor again, set the fancy zones for that monitor, etc. Fancy zones retains the zones for each monitor throughout the process.

@oyvindneu

This comment has been minimized.

Copy link

@oyvindneu oyvindneu commented Sep 6, 2019

Turn off "Use new zone editing experience"

DO NOT PRESS blue button "Edit zones"

Press Win - ~ ( OR Win - ö / Win - ø / Win - @ ) see comments in issue #203
Press e (now you can edit)
Press c (to create new zones)
Press d (to delete zones)
Press r (for reset)

@AlanMcBee

This comment has been minimized.

Copy link

@AlanMcBee AlanMcBee commented Sep 6, 2019

I tried #195 (comment) and it halfway worked. I was able to bring up the old editor, but it still created all the zones only on the primary monitor, even though it showed the possible grids to select on the floater toolbar on both monitors. When I selected the three column layout on my secondary monitor, it seems to apply the layout to my primary monitor.

tl;dr: that workaround is not reliable

@Michae1DX

This comment has been minimized.

Copy link

@Michae1DX Michae1DX commented Sep 6, 2019

Another work around is to change your "main monitor" setting, set the fancy zones in the new editor, change the main monitor again, set the fancy zones for that monitor, etc. Fancy zones retains the zones for each monitor throughout the process.

This seems to be working well. I have 3 monitors and used this method to set up zones for each. Very happy with the results.

@movedoa

This comment has been minimized.

Copy link

@movedoa movedoa commented Sep 6, 2019

Apart from different layouts for multimonitor it would be very nice to have different layouts per virtual desktop too. I have my communication apps an the first desktop and my working tools on the second. They require different layouts.

Is this something that is planned?

@stevemk14ebr

This comment has been minimized.

Copy link

@stevemk14ebr stevemk14ebr commented Sep 6, 2019

I believe the cause of this is the line

Rect workArea = System.Windows.SystemParameters.WorkArea;

MSDN says:

Gets the size of the work area on the primary display monitor.

So someone go fix that to get the work area of other monitors. Makes sense why the workaround works with this.

@TheMrJukes

This comment has been minimized.

Copy link
Collaborator

@TheMrJukes TheMrJukes commented Sep 6, 2019

@stevemk14ebr that is one of the places yes. I put a few "TODO: multimon" tags around that need to be figured out to get better multimon support. I'm going to be working on this over the weekend.

@smoli

This comment has been minimized.

Copy link

@smoli smoli commented Sep 9, 2019

The workaround I'm using right now as the old editor did not work for me:

  • Open Display Settings
  • Set monitor to primary display
  • Create a layout using the new editor for that monitor

Repeat for each monitor. FancyZones stores the layouts per monitor (most likely per screen coordinates) and they stay on their respective monitor even after it is not the primary anymore. Only drawback is that the layouts reserve the space for the taskbar although it may not be visible for "non-primaray" monitors.

@ziplock9000

This comment has been minimized.

Copy link

@ziplock9000 ziplock9000 commented Sep 9, 2019

+1 This is extremely important as many people using PT will have multiple monitors

@pbronez

This comment has been minimized.

Copy link

@pbronez pbronez commented Sep 9, 2019

Workaround above worked for me. However, when I enable "Override Windows Snap hotkeys," these hotkey only cycle the windows through zones on their current monitor. The windows should cycle through all zones regardless of monitor.

@TheMrJukes

This comment has been minimized.

Copy link
Collaborator

@TheMrJukes TheMrJukes commented Sep 9, 2019

However, when I enable "Override Windows Snap hotkeys," these hotkey only cycle the windows through zones on their current monitor. The windows should cycle through all zones regardless of monitor.

I agree it should. As a workaround for that, you can use Win+Shift+Arrow to move the window to your desired monitor and then Win+Arrow like normal to cycle through the zones.

@fabricebauer

This comment has been minimized.

Copy link

@fabricebauer fabricebauer commented Sep 10, 2019

Could you please also add the capability to define zones across several monitors? For instance I would like to define one single zone spanning two monitors (this is my current setup with ultramon for instance).
Thanks very much

@enricogior enricogior pinned this issue Sep 13, 2019
TheMrJukes added a commit that referenced this issue Sep 18, 2019
Fix for #195 - Fancy Zones new editor needs to support multiple monitors
Fix for #292 - Zone Editor opens behind PowerToys Window
@enricogior

This comment has been minimized.

Copy link
Collaborator Author

@enricogior enricogior commented Sep 18, 2019

Hi @fabricebauer
you should open a new issue with your suggestion since this issues is now closed.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.