[CI] Fix for building with Visual Studio 17.6 #25759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crutkas
added
the
Needs-Review
jaimecbernardo
approved these changes
May 2, 2023
BLM16
pushed a commit
to BLM16/PowerToys
that referenced
this pull request
Jun 22, 2023
* Disable building Stl Modules * [FindMyMouse] Fix C26495 errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Resolves issues building with Visual Studio 17.6 by disabling the building of C++/23 Standard Library Modules. Fixes struct member object initialization issue that triggers C26495 with FindMyMouse.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Built with both VS 17.5 and VS 17.6 Preview 5 to verify that both builds continue functioning properly.