Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a multi-distro spec file to build procdump #29

Merged
merged 1 commit into from Dec 1, 2018
Merged

Add a multi-distro spec file to build procdump #29

merged 1 commit into from Dec 1, 2018

Conversation

Conan-Kudo
Copy link
Contributor

This commit simultaneously removes the old way to produce a Debian package.

Signed-off-by: Neal Gompa ngompa13@gmail.com

@Conan-Kudo Conan-Kudo force-pushed the spec-pkgbuild branch 2 times, most recently from 847ccfa to 5e9f0ba Compare December 23, 2017 02:45
@Conan-Kudo
Copy link
Contributor Author

This is a slightly tweaked version of the spec I used here: https://build.opensuse.org/package/show/home:Pharaoh_Atem:procdump/procdump

In this case, the spec can be driven from the Makefile so that you can build the Debian or RPM packages from the Makefile.

@jahabibi jahabibi changed the base branch from development to master October 20, 2018 00:07
@josalem josalem requested a review from jahabibi October 20, 2018 00:07
@josalem josalem added the infrastructure General category for CI/CD and repo maintenance label Oct 20, 2018
@jahabibi
Copy link
Collaborator

Everything looks good! We have been doing some housekeeping with procdump recently, could you please rebase your changes on top of master.

@Conan-Kudo
Add a multi-distro spec file to build procdump
5568677 
This commit simultaneously removes the old way to produce a Debian package.

Signed-off-by: Neal Gompa <ngompa13@gmail.com>
@Conan-Kudo
Copy link
Contributor Author

@jahabibi I've rebased everything accordingly.

@Conan-Kudo
Copy link
Contributor Author

@jahabibi Note that I filled out the changelog section of the spec with the actual release information from GitHub, as I figured that'd be useful for people to be able get the changelog easily on installed systems. The expectation, of course, would be that the changelog would be filled out for subsequent releases...

If you'd rather not have a changelog, please let me know and I can roll it back to the generic "initial packaging" entry I previously had.

@Conan-Kudo
Copy link
Contributor Author

@jahabibi @josalem Can someone please review this, since I reworked this as requested?

@Conan-Kudo
Copy link
Contributor Author

Hello, is there anyone there to review and merge this?

jahabibi
jahabibi approved these changes Dec 1, 2018
View reviewed changes
Copy link
Collaborator

@jahabibi jahabibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@jahabibi jahabibi merged commit 1d03045 into Sysinternals:master Dec 1, 2018
@Conan-Kudo Conan-Kudo deleted the spec-pkgbuild branch December 1, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahabibi jahabibi jahabibi approved these changes

Assignees
No one assigned
Labels
infrastructure General category for CI/CD and repo maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Conan-Kudo @jahabibi @josalem