Use MCR image for hosting on Binder #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR can be tested on Binder, btw, using the link https://mybinder.org/v2/gh/microsoft/quantumkatas/cgranade/from-mc. |
tcNickolas
requested changes
Jul 19, 2019
There was a problem hiding this comment.
Could you please update your branch to use the latest master? Right now the Dockerfile uses 0.8.1907.1701 but the katas on your branch are still on 0.7.1905.3109, so the notebooks on Binder don't work (I get /snippet:(1,26): error QS6104: No namespace with that name exists. on the first task in BasicGates kata).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the Dockerfile for the katas to use the iqsharp-base image produced from the iqsharp-base image hosted on Microsoft Container Registry at mcr.microsoft.com/quantum/iqsharp-base. This should significantly reduce build times and make it much easier to maintain the Binder configuration for the katas.