From b2fed7eff562439fd5b5d6ba9eef7d55c43394a1 Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Wed, 8 Jun 2022 10:34:20 +0200 Subject: [PATCH 1/4] API review June 2022 --- Design/meetings/2022/api-design-2022-06.md | 42 ++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Design/meetings/2022/api-design-2022-06.md diff --git a/Design/meetings/2022/api-design-2022-06.md b/Design/meetings/2022/api-design-2022-06.md new file mode 100644 index 00000000000..b5d9aa1c2a4 --- /dev/null +++ b/Design/meetings/2022/api-design-2022-06.md @@ -0,0 +1,42 @@ +# Q# API Design Discussions / June 2022 + +Reviewers (in order by username): + +## Agenda + +- https://github.com/microsoft/QuantumLibraries/issues/593 +- https://github.com/microsoft/QuantumLibraries/issues/594 +- https://github.com/microsoft/QuantumLibraries/issues/595 + +## Discussion + +### Comparison operations + +**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/593 + +**Reviews**: +> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. + +**Consensus**: + +--- + +### Functions for smallest and largest representable fixed point + +**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/594 + +**Reviews**: +> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. + +**Consensus**: + +--- + +### Conversion functions for signed integers + +**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/595 + +**Reviews**: +> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. + +**Consensus**: From d948d2239d0e053b7dcbce33b7e8f003e96d92a9 Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Wed, 6 Jul 2022 02:59:59 -0700 Subject: [PATCH 2/4] Apply suggestions from code review Co-authored-by: Mariia Mykhailova --- Design/meetings/2022/api-design-2022-06.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Design/meetings/2022/api-design-2022-06.md b/Design/meetings/2022/api-design-2022-06.md index b5d9aa1c2a4..eccddf6f479 100644 --- a/Design/meetings/2022/api-design-2022-06.md +++ b/Design/meetings/2022/api-design-2022-06.md @@ -1,6 +1,6 @@ # Q# API Design Discussions / June 2022 -Reviewers (in order by username): +Reviewers (in order by username): @tcNickolas ## Agenda @@ -15,6 +15,7 @@ Reviewers (in order by username): **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/593 **Reviews**: +* @tcNickolas, *approve*, left a comment > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: @@ -26,6 +27,7 @@ Reviewers (in order by username): **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/594 **Reviews**: +* @tcNickolas, *approve*, left a comment > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: @@ -37,6 +39,7 @@ Reviewers (in order by username): **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/595 **Reviews**: +* @tcNickolas, *approve*, left a comment > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: From cd420e1a3a50f8986843a6ddf038af42b9b730ea Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Wed, 6 Jul 2022 22:03:59 -0700 Subject: [PATCH 3/4] Apply suggestions from code review Co-authored-by: Cassandra Granade --- Design/meetings/2022/api-design-2022-06.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Design/meetings/2022/api-design-2022-06.md b/Design/meetings/2022/api-design-2022-06.md index eccddf6f479..60d89a0b200 100644 --- a/Design/meetings/2022/api-design-2022-06.md +++ b/Design/meetings/2022/api-design-2022-06.md @@ -1,6 +1,6 @@ # Q# API Design Discussions / June 2022 -Reviewers (in order by username): @tcNickolas +Reviewers (in order by username): @tcNickolas, @cgranade ## Agenda @@ -15,6 +15,7 @@ Reviewers (in order by username): @tcNickolas **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/593 **Reviews**: +- @cgranade, *comment*: Does the `action` input to `ApplyControlledOnLessThanFxP` need to be adjointable? Should there be a separate `Adj` variant? We may also want to describe quickly how this proposal works with the outstanding proposal for numerics refactoring all-up (https://github.com/microsoft/QuantumLibraries/issues/337). * @tcNickolas, *approve*, left a comment > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. @@ -26,7 +27,7 @@ Reviewers (in order by username): @tcNickolas **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/594 -**Reviews**: +**Reviews**: @cgranade, *approve*, same comment as above (https://github.com/microsoft/QuantumLibraries/issues/337). * @tcNickolas, *approve*, left a comment > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. @@ -39,6 +40,7 @@ Reviewers (in order by username): @tcNickolas **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/595 **Reviews**: +* @cgranade: *comment*. We should coordinate this with the Q# language discussion around bit vectors in general. @swernli and @bettinaheim in particular may want to provide input here. * @tcNickolas, *approve*, left a comment > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. From 5f7c29c2a762f78710ee3d2319606dcd7512e2b5 Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Wed, 6 Jul 2022 22:06:28 -0700 Subject: [PATCH 4/4] Apply suggestions from code review --- Design/meetings/2022/api-design-2022-06.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Design/meetings/2022/api-design-2022-06.md b/Design/meetings/2022/api-design-2022-06.md index 60d89a0b200..3e390a9dbb9 100644 --- a/Design/meetings/2022/api-design-2022-06.md +++ b/Design/meetings/2022/api-design-2022-06.md @@ -19,7 +19,7 @@ Reviewers (in order by username): @tcNickolas, @cgranade * @tcNickolas, *approve*, left a comment > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. -**Consensus**: +**Consensus**: *approve* subject to comments to be addressed in the issue, discussion will be deferred to issue. --- @@ -31,7 +31,7 @@ Reviewers (in order by username): @tcNickolas, @cgranade * @tcNickolas, *approve*, left a comment > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. -**Consensus**: +**Consensus**: *approve* --- @@ -44,4 +44,4 @@ Reviewers (in order by username): @tcNickolas, @cgranade * @tcNickolas, *approve*, left a comment > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. -**Consensus**: +**Consensus**: *approve* subject to comments to be addressed in the issue, discussion will be deferred to issue.