Access _Clocptr statically, instead of through an instance #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Sep 7, 2022
|
Thanks, and good catch! This is indeed static, and we're within the class itself here, so there's no reason to access it like a non-static data member: Line 217 in f9697fc |
Closed
AraHaan
approved these changes
Sep 8, 2022
|
Also, I checked and this appears to be the only occurrence. |
strega-nil-ms
approved these changes
Sep 12, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for this code cleanup! 😸 😸 😸 |
CaseyCarter
pushed a commit
to CaseyCarter/STL
that referenced
this pull request
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.