From 0c9b1e49d30c8563bd35261585b8aafdee30633d Mon Sep 17 00:00:00 2001 From: "A. Jiang" Date: Mon, 6 Feb 2023 16:28:07 +0800 Subject: [PATCH 1/2] Enable some formerly buggy test cases for MSVC DevCom-10111923 and DevCom-10112408 are reported to be fixed, let's test relative cases. --- tests/std/tests/P0088R3_variant/test.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/std/tests/P0088R3_variant/test.cpp b/tests/std/tests/P0088R3_variant/test.cpp index 4e4e0cd18e..fc01cdb312 100644 --- a/tests/std/tests/P0088R3_variant/test.cpp +++ b/tests/std/tests/P0088R3_variant/test.cpp @@ -7673,10 +7673,8 @@ namespace msvc { }; using VarTestConv = std::variant; -#if defined(__clang__) || defined(__EDG__) // TRANSITION, DevCom-10111923 and DevCom-10112408 assert(std::visit(std::identity{}, VarTestConv{convertible_to_immobile_one{}}).x == 1729); assert(std::visit(std::identity{}, VarTestConv{convertible_to_immobile_other{}}).x == 1138); -#endif // TRANSITION, DevCom-10111923 and DevCom-10112408 auto immobile_converter = [](auto src) -> immobile_data { return src; }; assert(std::visit(immobile_converter, VarTestConv{convertible_to_immobile_one{}}).x == 1729); assert(std::visit(immobile_converter, VarTestConv{convertible_to_immobile_other{}}).x == 1138); From f363ddb4ee18bd33f2b8c7818b6fe7c66d5901b5 Mon Sep 17 00:00:00 2001 From: "A. Jiang" Date: Mon, 6 Feb 2023 23:07:07 +0800 Subject: [PATCH 2/2] Restore skipping as DevCom-10112408 is not yet fixed --- tests/std/tests/P0088R3_variant/test.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/std/tests/P0088R3_variant/test.cpp b/tests/std/tests/P0088R3_variant/test.cpp index fc01cdb312..7c71757d6c 100644 --- a/tests/std/tests/P0088R3_variant/test.cpp +++ b/tests/std/tests/P0088R3_variant/test.cpp @@ -7673,8 +7673,10 @@ namespace msvc { }; using VarTestConv = std::variant; +#if defined(__clang__) || defined(__EDG__) // TRANSITION, DevCom-10112408 assert(std::visit(std::identity{}, VarTestConv{convertible_to_immobile_one{}}).x == 1729); assert(std::visit(std::identity{}, VarTestConv{convertible_to_immobile_other{}}).x == 1138); +#endif // TRANSITION, DevCom-10112408 auto immobile_converter = [](auto src) -> immobile_data { return src; }; assert(std::visit(immobile_converter, VarTestConv{convertible_to_immobile_one{}}).x == 1729); assert(std::visit(immobile_converter, VarTestConv{convertible_to_immobile_other{}}).x == 1138);