Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vega spec implementation, missing parts #396

Open
Cyrik opened this issue Jan 14, 2022 · 5 comments
Open

Vega spec implementation, missing parts #396

Cyrik opened this issue Jan 14, 2022 · 5 comments

Comments

@Cyrik
Copy link

Cyrik commented Jan 14, 2022

It seems that click events are not implemented yet, is this correct?
Is this not possible because of the 3d canvas or merely not done yet?

Is there any place to see which part of the vega spec is implemented? For my specs most things are working, only click, hover and some color stuff seems to be broken.

@danmarshall
Copy link
Contributor

Hi @Cyrik , there's some investigation needed to rationalize the 3D canvas back to Vega's event types. For example, in a 3D view at an oblique camera angle, what should be sent to the mousemove event's x,y position? And many similar questions. We haven't done this investigation as we got as far enough to do some rendering.

Next there would be integrating the event stream from the 3D renderer back into the Vega instance. We don't have the code for this but it should be possible.

@Cyrik
Copy link
Author

Cyrik commented Jan 19, 2022

Makes total sense, thank you for the explanation!
I was hoping you had it partially implemented since the full demo has tooltips and selection working. If it's not too much work, could you point me to that code? Maybe I could adapt it to my problem or is the full demo not based on a vega spec?

BTW great work so far, very much looking forward to using SandDance for my projects.

@danmarshall
Copy link
Contributor

danmarshall commented Jan 20, 2022

I haven't looked that deeply into that aspect of a renderer, but you may be able to work backwards from vega-scenegraph, see the CanvasHandler.js and SVGHandler.js files.

@Cyrik
Copy link
Author

Cyrik commented Jan 21, 2022

@danmarshall Thank you, but I meant the code in SandDance that does the selection and tooltip display. Unless of course, the full SandDance demo isn't based on the vega-deck.gl module.

Oh and if this is the wrong place to ask these follow-up questions I understand.

@danmarshall
Copy link
Contributor

This is the right repo to have the discussion :)

Our deck.gl handlers are here: https://github.com/microsoft/SandDance/blob/master/packages/vega-deck.gl/src/layers.ts

The thing to know is that these handlers are a departure from the Vega renderer way of handling. So they are more deck.gl style instead of Vega style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants