Support subquests #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcCote
commented
Aug 29, 2018
textworld/agents/walkthrough.py
Outdated
|
|
||
| # Load command from the generated game. | ||
| self._commands = iter(env.game.quests[0].commands) | ||
| self._commands = iter(env.game.quests[-1].commands) |
Contributor
Author
There was a problem hiding this comment.
I need to rethink this. It is not guaranteed the last quest will have all the commands needed to solve the whole game. It should be the case for games generated via the nonlinear chaining function but not for handcrafted games.
MarcCote
force-pushed
the
subquests
branch
2 times, most recently
from
8db6bf2 to
96f691d
Compare
MarcCote
force-pushed
the
subquests
branch
2 times, most recently
from
a62c5d5 to
d183e45
Compare
This was referenced Sep 20, 2018
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for subquests/multi-quests. Here are the highlights:
--only-last-actionis True and there is more than one subquest, the generated text objective describes each subquest's last action in order.NB: this PR is based on top of #29.