Support subquests - part 1 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcCote
force-pushed
the
enh_dependency_tree
branch
from
54f845e to
b3d4a6a
Compare
…rack multiple quests.
MarcCote
force-pushed
the
enh_dependency_tree
branch
from
b3d4a6a to
00ebb80
Compare
tavianator
suggested changes
Sep 24, 2018
|
|
||
| def __init__(self, element_type=DependencyTreeElement): | ||
| self.root = None | ||
| def __init__(self, element_type: DependencyTreeElement = DependencyTreeElement, trees: Iterable["DependencyTree"] = []): |
Contributor
There was a problem hiding this comment.
Should be
element_type: type = DependencyTreeElementI think
Contributor
Author
There was a problem hiding this comment.
Oh right. Good catch.
tavianator
approved these changes
Sep 25, 2018
This was referenced Sep 26, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of a series which will bring support to generate games with multiple subquests. It supersedes part of #30 and the remaining modification will be added in subsequent PRs.
DependencyTreenow supports more than one root.ActionDependencyTreehas a better heuristic to be flattened, i.e. building a policy from the dependency tree.GameProgressioncan now track multiple quests at the same time.QuestProgressionnow has a better way of compressing its winning policy (i.e. a sequence of actions that leads to the quest completion).