Adding GameOptions
#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2018
MarcCote
force-pushed
the
enh_game_options
branch
from
f8d2b2e to
861b77e
Compare
Contributor
Author
|
Rebased on top of mater. |
tavianator
reviewed
Oct 3, 2018
textworld/generator/game.py
Outdated
| """ | ||
|
|
||
| def __init__(self): | ||
| self.chaining_options = ChainingOptions() |
Contributor
There was a problem hiding this comment.
Maybe you can drop _options from these? options.chaining_options.whatever is a bit redundant
tavianator
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new class
GameOptionsthat contains all the needed information to generate games.NB: This PR should be merged after #43.