From 55c95740037c5dd8354e5f5da2b8750d8e924882 Mon Sep 17 00:00:00 2001 From: Robert Gruen Date: Wed, 29 Oct 2025 16:54:27 -0700 Subject: [PATCH 1/8] Temporarily disabling path check. due to this workflow being required for main branch --- .github/workflows/smoke-tests.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/smoke-tests.yml b/.github/workflows/smoke-tests.yml index ac32608ac..2efdbd8f4 100644 --- a/.github/workflows/smoke-tests.yml +++ b/.github/workflows/smoke-tests.yml @@ -9,12 +9,12 @@ on: workflow_dispatch: push: branches: ["main"] - paths: - - 'ts/**' # only run on changes to ts/ folder + #paths: + # - 'ts/**' # only run on changes to ts/ folder pull_request_target: branches: ["main"] - paths: - - 'ts/**' # only run on changes to ts/ folder + #paths: + # - 'ts/**' # only run on changes to ts/ folder merge_group: branches: ["main"] concurrency: From 73bb87b1d8cf01ef29aea0428337569ac726f05a Mon Sep 17 00:00:00 2001 From: Robert Gruen Date: Wed, 29 Oct 2025 17:04:25 -0700 Subject: [PATCH 2/8] whitepsaceupdate --- ts/examples/cacheRESTEndpoint/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts/examples/cacheRESTEndpoint/README.md b/ts/examples/cacheRESTEndpoint/README.md index 168682061..4d0f218bc 100644 --- a/ts/examples/cacheRESTEndpoint/README.md +++ b/ts/examples/cacheRESTEndpoint/README.md @@ -4,7 +4,7 @@ This example shows how to host the AgentCache and serve HTTP rest calls to return cach hits/misses. This is **sample code**. -## Running +## Running The server can be started with `npm run start` in this package's directory or launch it from the debug menu in VS code. Once it is up and running you can `http://localhost:10482` using a web browser to issue API calls. From c9dfea8d9b17860d3b0b67b8dc41eb3e2f8ed922 Mon Sep 17 00:00:00 2001 From: Robert Gruen Date: Wed, 29 Oct 2025 17:08:57 -0700 Subject: [PATCH 3/8] lint --- .github/workflows/smoke-tests.yml | 11 +++++++++++ ts/examples/cacheRESTEndpoint/README.md | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/smoke-tests.yml b/.github/workflows/smoke-tests.yml index 2efdbd8f4..67054dd7b 100644 --- a/.github/workflows/smoke-tests.yml +++ b/.github/workflows/smoke-tests.yml @@ -80,6 +80,17 @@ jobs: with: ref: ${{ github.event.pull_request.head.sha }} + - name: Determine if relevant files changed # don't run tests if we didn't modify an code under ts/ + id: changes + run: | + git fetch origin ${{ github.base_ref }} + CHANGED=$(git diff --name-only origin/${{ github.base_ref }} | grep -E '^(ts/)') || true + if [ -z "$CHANGED" ]; then + echo "changed=false" >> $GITHUB_OUTPUT + else + echo "changed=true" >> $GITHUB_OUTPUT + + - uses: dorny/paths-filter@v3 id: filter continue-on-error: true diff --git a/ts/examples/cacheRESTEndpoint/README.md b/ts/examples/cacheRESTEndpoint/README.md index 4d0f218bc..168682061 100644 --- a/ts/examples/cacheRESTEndpoint/README.md +++ b/ts/examples/cacheRESTEndpoint/README.md @@ -4,7 +4,7 @@ This example shows how to host the AgentCache and serve HTTP rest calls to return cach hits/misses. This is **sample code**. -## Running +## Running The server can be started with `npm run start` in this package's directory or launch it from the debug menu in VS code. Once it is up and running you can `http://localhost:10482` using a web browser to issue API calls. From e17870ed8a6ba812f89a736dac72a223e158b7be Mon Sep 17 00:00:00 2001 From: Robert Gruen Date: Wed, 29 Oct 2025 17:09:45 -0700 Subject: [PATCH 4/8] removed file check --- .github/workflows/smoke-tests.yml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.github/workflows/smoke-tests.yml b/.github/workflows/smoke-tests.yml index 67054dd7b..2efdbd8f4 100644 --- a/.github/workflows/smoke-tests.yml +++ b/.github/workflows/smoke-tests.yml @@ -80,17 +80,6 @@ jobs: with: ref: ${{ github.event.pull_request.head.sha }} - - name: Determine if relevant files changed # don't run tests if we didn't modify an code under ts/ - id: changes - run: | - git fetch origin ${{ github.base_ref }} - CHANGED=$(git diff --name-only origin/${{ github.base_ref }} | grep -E '^(ts/)') || true - if [ -z "$CHANGED" ]; then - echo "changed=false" >> $GITHUB_OUTPUT - else - echo "changed=true" >> $GITHUB_OUTPUT - - - uses: dorny/paths-filter@v3 id: filter continue-on-error: true From 3cafd6c7f8a6489da200fcde8603d2d4aee328fe Mon Sep 17 00:00:00 2001 From: Robert Gruen Date: Wed, 29 Oct 2025 17:16:08 -0700 Subject: [PATCH 5/8] trigger change --- .github/workflows/smoke-tests.yml | 18 +++++++++++++++++- ts/examples/schemaStudio/src/input.txt | 2 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/.github/workflows/smoke-tests.yml b/.github/workflows/smoke-tests.yml index 2efdbd8f4..b10319d37 100644 --- a/.github/workflows/smoke-tests.yml +++ b/.github/workflows/smoke-tests.yml @@ -33,7 +33,23 @@ env: # DEBUG: typeagent:* # TypeAgent debug messages jobs: + check-changes: + runs-on: ubuntu-latest + steps: + - name: Determine if relevant files changed # don't run tests if we didn't modify an code under ts/ + id: changes + run: | + git fetch origin ${{ github.base_ref }} + CHANGED=$(git diff --name-only origin/${{ github.base_ref }} | grep -E '^(ts/)') || true + if [ -z "$CHANGED" ]; then + echo "changed=false" >> $GITHUB_OUTPUT + else + echo "changed=true" >> $GITHUB_OUTPUT + + shell_and_cli: + needs: check-changes + if: needs.check-changes.outputs.changed == 'true' #environment: ${{ github.event_name == 'pull_request_target' && 'development-fork' || 'development' }} # required for federated credentials environment: development-fork strategy: @@ -126,7 +142,7 @@ jobs: node tools/scripts/getKeys.mjs --vault build-pipeline-kv working-directory: ts - - name: Test CLI - smoke + - name: Test CLI - smoke run: | npm run start:dev 'prompt' 'why is the sky blue' working-directory: ts/packages/cli diff --git a/ts/examples/schemaStudio/src/input.txt b/ts/examples/schemaStudio/src/input.txt index 98b255e92..c3b958320 100644 --- a/ts/examples/schemaStudio/src/input.txt +++ b/ts/examples/schemaStudio/src/input.txt @@ -6,7 +6,7 @@ @fromSchema --action GetAlbumAction --count 20 --facets "Phrase Structure, Album Name, Slang" --example "Yo, load up Nevermind by Nirvana" -@variations "Yo, play me some Goldberg Variations by Bach!" --facets "Composer, Piece, Slang" --depth 2 --progress +@variations "Yo, play me some Goldberg Variations by Bach!" --facets "Composer, Piece, Slang" --depth 3 --progress # Interactive mode only "Play me Aja by Steely Dan" --facets "Composer, Piece, Slang" --type "similar" From 68f3a8e616225fa3735784069ab6b382bfacf6c3 Mon Sep 17 00:00:00 2001 From: Robert Gruen Date: Wed, 29 Oct 2025 17:16:34 -0700 Subject: [PATCH 6/8] remved new branching --- .github/workflows/smoke-tests.yml | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/.github/workflows/smoke-tests.yml b/.github/workflows/smoke-tests.yml index b10319d37..4144853bf 100644 --- a/.github/workflows/smoke-tests.yml +++ b/.github/workflows/smoke-tests.yml @@ -33,23 +33,7 @@ env: # DEBUG: typeagent:* # TypeAgent debug messages jobs: - check-changes: - runs-on: ubuntu-latest - steps: - - name: Determine if relevant files changed # don't run tests if we didn't modify an code under ts/ - id: changes - run: | - git fetch origin ${{ github.base_ref }} - CHANGED=$(git diff --name-only origin/${{ github.base_ref }} | grep -E '^(ts/)') || true - if [ -z "$CHANGED" ]; then - echo "changed=false" >> $GITHUB_OUTPUT - else - echo "changed=true" >> $GITHUB_OUTPUT - - shell_and_cli: - needs: check-changes - if: needs.check-changes.outputs.changed == 'true' #environment: ${{ github.event_name == 'pull_request_target' && 'development-fork' || 'development' }} # required for federated credentials environment: development-fork strategy: From 9a2444ffdc05c7f6637c17560b60a4b13cba3770 Mon Sep 17 00:00:00 2001 From: Robert Gruen Date: Wed, 29 Oct 2025 17:48:06 -0700 Subject: [PATCH 7/8] condition all the long running stuff to only go if ts/ files have changed --- .github/workflows/smoke-tests.yml | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/.github/workflows/smoke-tests.yml b/.github/workflows/smoke-tests.yml index 4144853bf..56f3c1317 100644 --- a/.github/workflows/smoke-tests.yml +++ b/.github/workflows/smoke-tests.yml @@ -87,34 +87,40 @@ jobs: filters: | ts: - "ts/**" - - ".github/workflows/build-ts.yml" + - ".github/workflows/smoke-tests.yml" - uses: pnpm/action-setup@v4 + if: ${{ steps.filter.outputs.ts != 'false' }} name: Install pnpm with: package_json_file: ts/package.json - uses: actions/setup-node@v4 + if: ${{ steps.filter.outputs.ts != 'false' }} with: node-version: ${{ matrix.version }} cache: "pnpm" cache-dependency-path: ts/pnpm-lock.yaml - name: Install dependencies + if: ${{ steps.filter.outputs.ts != 'false' }} working-directory: ts run: | pnpm install --frozen-lockfile --strict-peer-dependencies - name: Install Playwright Browsers + if: ${{ steps.filter.outputs.ts != 'false' }} run: pnpm exec playwright install --with-deps working-directory: ts/packages/shell - name: Build + if: ${{ steps.filter.outputs.ts != 'false' }} working-directory: ts run: | npm run build - name: Login to Azure + if: ${{ steps.filter.outputs.ts != 'false' }} uses: azure/login@v2.2.0 with: client-id: ${{ secrets.AZUREAPPSERVICE_CLIENTID_5B0D2D6BA40F4710B45721D2112356DD }} @@ -122,24 +128,26 @@ jobs: subscription-id: ${{ secrets.AZUREAPPSERVICE_SUBSCRIPTIONID_F36C1F2C4B2C49CA8DD5C52FAB98FA30 }} - name: Get Keys + if: ${{ steps.filter.outputs.ts != 'false' }} run: | node tools/scripts/getKeys.mjs --vault build-pipeline-kv working-directory: ts - - name: Test CLI - smoke + - name: Test CLI - smoke + if: ${{ steps.filter.outputs.ts != 'false' }} run: | npm run start:dev 'prompt' 'why is the sky blue' working-directory: ts/packages/cli - name: Shell Tests - full (windows) - if: ${{ runner.os == 'windows' }} + if: ${{ steps.filter.outputs.ts != 'false' && runner.os == 'windows'}} timeout-minutes: 60 run: | npm run shell:test working-directory: ts/packages/shell - name: Shell Tests - smoke (linux) - if: ${{ runner.os == 'Linux' }} + if: ${{ steps.filter.outputs.ts != 'false' && runner.os == 'Linux' }} timeout-minutes: 60 run: | Xvfb :99 -screen 0 1600x1200x24 & export DISPLAY=:99 @@ -147,7 +155,7 @@ jobs: working-directory: ts/packages/shell - name: Live Tests (Linux) - if: ${{ runner.os == 'Linux' }} + if: ${{ steps.filter.outputs.ts != 'false' && runner.os == 'Linux' }} timeout-minutes: 60 run: | npm run test:live From 3ec76c2fad92cfcc9f6a37699aaf2df03bea7e40 Mon Sep 17 00:00:00 2001 From: Robert Gruen Date: Wed, 29 Oct 2025 18:14:58 -0700 Subject: [PATCH 8/8] removed path comments --- .github/workflows/smoke-tests.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/smoke-tests.yml b/.github/workflows/smoke-tests.yml index 56f3c1317..9739e1a21 100644 --- a/.github/workflows/smoke-tests.yml +++ b/.github/workflows/smoke-tests.yml @@ -9,12 +9,8 @@ on: workflow_dispatch: push: branches: ["main"] - #paths: - # - 'ts/**' # only run on changes to ts/ folder pull_request_target: branches: ["main"] - #paths: - # - 'ts/**' # only run on changes to ts/ folder merge_group: branches: ["main"] concurrency: