test(dispatcher): widen selectFromPartitions wall-time threshold to 120ms#2317
Merged
Conversation
TalZaccai
force-pushed
the
dev/talzacc/fix-flaky-partitions-test
branch
from
d90488b to
934646e
Compare
TalZaccai
force-pushed
the
dev/talzacc/fix-flaky-partitions-test
branch
from
934646e to
c6eac37
Compare
TalZaccai
changed the title
TalZaccai
force-pushed
the
dev/talzacc/fix-flaky-partitions-test
branch
from
c6eac37 to
3bd0dc8
Compare
TalZaccai
force-pushed
the
dev/talzacc/fix-flaky-partitions-test
branch
from
3bd0dc8 to
8e23458
Compare
TalZaccai
changed the title
…20ms The "all partitions run in parallel" test asserts elapsed < 80ms for 3 partitions × 20ms delays. PR #2296 (May 6) added per-partition AbortSignal plumbing through selectFromPartitions, adding a few ms of overhead per partition and pushing wall-time past 80ms on shared CI runners. Observed failures since May 7 on ubuntu-latest at 86ms and 108ms — too consistent to be normal flake. Bumping the threshold from 80ms → 120ms absorbs the new overhead with headroom while still catching a genuine serial-await regression (3 × 20ms = 60ms minimum, but combined with the spread check this remains a meaningful guard). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
TalZaccai
force-pushed
the
dev/talzacc/fix-flaky-partitions-test
branch
from
8e23458 to
64a4eca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(dispatcher): widen
selectFromPartitionswall-time threshold to 120msThe "all partitions run in parallel" test asserts
elapsed < 80msfor3 partitions × 20ms delays. PR #2296 (May 6) added per-partition
AbortSignalplumbing throughselectFromPartitions, adding a few msof overhead per partition and pushing wall-time past 80ms on shared CI
runners.
Evidence
PR #2296 merged May 6. Failures start May 7. Pre-#2296 runs
back weeks: all green. The 86ms reading repeating exactly across runs
suggests the new abort-plumbing overhead landed deterministically just
above the old threshold.
Fix
Bump the assertion from
< 80msto< 120ms. That absorbs theobserved overhead (108ms worst case) with a small margin while keeping
the spread check and a meaningful upper bound — a serial-await
regression on these 20ms delays would still take ≥60ms minimum and
combined with the spread check this remains a useful guard.