Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property of AudioContext state API #30

Merged
merged 1 commit into from Dec 11, 2015

Conversation

@rixrix
Copy link

@rixrix rixrix commented Dec 9, 2015

Hi

This fixes microsoft/TypeScript#5816

This is my first PR, would be good if someone can give feedback. thanks

@msftclas
Copy link

@msftclas msftclas commented Dec 9, 2015

Hi @rixrix, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@msftclas msftclas commented Dec 9, 2015

@rixrix, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Dec 9, 2015

the webidl files are not supposed to change. please see https://github.com/Microsoft/TSJS-lib-generator#contribution-guide for how you can augment definitions.

@rixrix
Copy link
Author

@rixrix rixrix commented Dec 9, 2015

@mhegazy great, I'll look into it. thanks

@rixrix rixrix force-pushed the rixrix:AudioContext_state branch from c1c07d6 to e9be0cb Dec 9, 2015
@rixrix
Copy link
Author

@rixrix rixrix commented Dec 9, 2015

@mhegazy if you could look at it again, that'd be great. Previous change set was definitely a mistake. cheers

@mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Dec 9, 2015

👍

@zhengbli
Copy link
Contributor

@zhengbli zhengbli commented Dec 11, 2015

👍 Thanks for the contribution @rixrix !

zhengbli added a commit that referenced this pull request Dec 11, 2015
Add property of AudioContext state API
@zhengbli zhengbli merged commit 472b4b1 into microsoft:master Dec 11, 2015
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@rixrix rixrix deleted the rixrix:AudioContext_state branch Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants