Switch KeyboardEvent attribute from keyCode to key #1083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this code base, I saw that the code is using
key
instead ofkeyCode
.I guess unifying could be good.
Keycodes list
http://www.javascripter.net/faq/keycodes.htm
Did double-check on MDN
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code