-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix z-index conflict between aside and sidebar in mobile view #3282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@microsoft-github-policy-service agree |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3282.centralus.5.azurestaticapps.net |
|
This does seem like an improvement but https://victorious-plant-05c166c10-3282.centralus.5.azurestaticapps.net/docs/handbook/declaration-files/templates/module-class-d-ts.html shows that the sidebar still overlaps content 😞 |
The solution I provided (almost 2 months ago) deals with the z-index conflict with the content appearing within the sidebar when the sidebar is active. Having taken a look at the link provided, I'm slightly puzzled. You mentioned that the sidebar overlaps the content - isn't that the desired outcome when you select the hamburger menu - for the sidebar to be on top of the content? Could you clarify what the expected behavior should be? I want to ensure we’re aligned and address any remaining concerns effectively. I appreciate your follow-up on this. |
|
Now, this issue is certainly unrelated to your change since I'm pretty sure this is a regression introduced in some other change, but it is a little unfortunate to fix the z-index and then it still covers content 😄 |
|
This PR affects code added in #3236; I don't see it breaking the accessibility fix in my test, so that's good. |
Thank you for pointing that out! I did notice the issue, and I agree—it’s not ideal to leave it as is. To address this, I’ll work on making the site more mobile-friendly and will submit a pull request in the coming days with a proposed improvement. Looking forward to your feedback once it’s ready! 😊 |

This PR fixes a CSS z-index conflict in mobile view where the aside is overlapping the sidebar.