Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol-named properties get element-access completions #19349

Closed
DanielRosenwasser opened this issue Oct 19, 2017 · 2 comments

Comments

@DanielRosenwasser
Copy link
Member

commented Oct 19, 2017

const c = Symbol();
let obj = { [Symbol.iterator]: 100 };
let a = obj['/**/']

Go to the /**/ marker and request a completion.

Expected: No completions.
Actual: Completions for __@iterator!

Currently with #15473, this is exacerbated.

@mhegazy

This comment has been minimized.

Copy link

commented Oct 19, 2017

PRs welcomed.

@rbuckton

This comment has been minimized.

Copy link
Member

commented Oct 22, 2017

I created a PR to fix this, since this is more noticeable with the dynamic names PR.

@mhegazy mhegazy added the Fixed label Oct 30, 2017

@mhegazy mhegazy modified the milestones: Community, TypeScript 2.7 Oct 30, 2017

@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.