Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word based suggestions returned when starting to type spread #45436

Closed
mjbvz opened this issue Aug 12, 2021 · 1 comment
Closed

Word based suggestions returned when starting to type spread #45436

mjbvz opened this issue Aug 12, 2021 · 1 comment

Comments

@mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Aug 12, 2021

Discovered in microsoft/vscode#130096

Bug Report

馃攷 Search Terms

  • word based suggestions
  • javascript
  • spread
  • warning suggestions

馃晽 Version & Regression Information

4.4.1-rc

馃捇 Code

  1. In a JS file:
const abc = {};

({ })
  1. Put cursor inside the object literal and type: .

馃檨 Actual behavior

JS warning suggestions (word based suggestions) are returned:

[Trace  - 22:36:59.359] <semantic> Response received: completionInfo (308). Request took 7 ms. Success: true 
Result: {
    "isGlobalCompletion": false,
    "isMemberCompletion": true,
    "isNewIdentifierLocation": false,
    "entries": [
        {
            "name": "abc",
            "kind": "warning",
            "kindModifiers": "",
            "sortText": "17"
        }
    ]
}

馃檪 Expected behavior

No suggestions should be returned in this case since the user is likely starting to type a spread operator

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Aug 24, 2021

Rescheduling to 4.5. @mjbvz if we need we can easily cherry-pick the fix into a patch for 4.4 if necessary.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants