Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type inference in conditional types #21496

Merged
merged 66 commits into from Feb 3, 2018
Merged

Type inference in conditional types #21496

merged 66 commits into from Feb 3, 2018

Commits on Dec 5, 2017

  1. Initial implementation of conditional type operator

    @ahejlsberg
    ahejlsberg committed Dec 5, 2017
    Copy the full SHA
    57ca768 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2017

  1. Add type relationships and distribute over union types

    @ahejlsberg
    ahejlsberg committed Dec 8, 2017
    Copy the full SHA
    063eed1 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2017

  1. Add 'T extends U' type operator

    @ahejlsberg
    ahejlsberg committed Dec 12, 2017
    Copy the full SHA
    ec2bdfd View commit details
    Browse the repository at this point in the history

  2. Clean up isGenericXXXType functions

    @ahejlsberg
    ahejlsberg committed Dec 12, 2017
    Copy the full SHA
    43e195d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2017

  1. Introduce TypeFlags.Instatiable

    @ahejlsberg
    ahejlsberg committed Dec 13, 2017
    Copy the full SHA
    61225cc View commit details
    Browse the repository at this point in the history

  2. Rename TypeVariable to InstantiableType

    @ahejlsberg
    ahejlsberg committed Dec 13, 2017
    Copy the full SHA
    9f74a7a View commit details
    Browse the repository at this point in the history

  3. Inference for conditional and extends type operators

    @ahejlsberg
    ahejlsberg committed Dec 13, 2017
    Copy the full SHA
    20434fa View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @ahejlsberg
    ahejlsberg committed Dec 13, 2017
    Copy the full SHA
    ddc631c View commit details
    Browse the repository at this point in the history

  5. Improve conditional type constraint checking

    @ahejlsberg
    ahejlsberg committed Dec 13, 2017
    Copy the full SHA
    000f121 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2017

  1. Handle constraints for distributive conditional types

    @ahejlsberg
    ahejlsberg committed Dec 16, 2017
    Copy the full SHA
    27b945b View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2017

  1. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Dec 17, 2017
    Copy the full SHA
    f59e2e6 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2017

  1. Move JsxAttributes and MarkerType from TypeFlags to ObjectFlags

    @ahejlsberg
    ahejlsberg committed Dec 18, 2017
    Copy the full SHA
    14590f1 View commit details
    Browse the repository at this point in the history

  2. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Dec 18, 2017
    Copy the full SHA
    100e4f6 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2017

  1. Parse xxx? as JSDoc type when not followed by token that starts type

    @ahejlsberg
    ahejlsberg committed Dec 19, 2017
    Copy the full SHA
    c5fd2f1 View commit details
    Browse the repository at this point in the history

  2. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Dec 19, 2017
    Copy the full SHA
    341c397 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2017

  1. Fix linting error

    @ahejlsberg
    ahejlsberg committed Dec 20, 2017
    Copy the full SHA
    3f4911f View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2018

  1. Merge branch 'master' into conditionalTypes 

    # Conflicts:
#	src/compiler/checker.ts
    @ahejlsberg
    ahejlsberg committed Jan 3, 2018
    Copy the full SHA
    abc8110 View commit details
    Browse the repository at this point in the history

  2. Propagate both TypeFlags and ObjectFlags in getSpreadType

    @ahejlsberg
    ahejlsberg committed Jan 3, 2018
    Copy the full SHA
    bb23bb2 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2018

  1. Eagerly evaluate S extends T when S is definitely or definitely not a… 

    …ssignable to T
    @ahejlsberg
    ahejlsberg committed Jan 14, 2018
    Copy the full SHA
    c10a552 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2018

  1. Revert to extends check being part of conditional type

    @ahejlsberg
    ahejlsberg committed Jan 15, 2018
    Copy the full SHA
    53b1572 View commit details
    Browse the repository at this point in the history

  2. Remove 'T extends U' type constructor

    @ahejlsberg
    ahejlsberg committed Jan 15, 2018
    Copy the full SHA
    5094f76 View commit details
    Browse the repository at this point in the history

  3. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Jan 15, 2018
    Copy the full SHA
    925da86 View commit details
    Browse the repository at this point in the history

  4. Introduce substitution types to use for constrained type parameters

    @ahejlsberg
    ahejlsberg committed Jan 15, 2018
    Copy the full SHA
    e8d1740 View commit details
    Browse the repository at this point in the history

  5. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Jan 15, 2018
    Copy the full SHA
    15baf0e View commit details
    Browse the repository at this point in the history

  6. Properly handle 'any' and 'never' as conditional check type

    @ahejlsberg
    ahejlsberg committed Jan 15, 2018
    Copy the full SHA
    9598acd View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. Erase substitution types in type references and type alias instantiat… 

    …ions
    @ahejlsberg
    ahejlsberg committed Jan 16, 2018
    Copy the full SHA
    e96ec8c View commit details
    Browse the repository at this point in the history

  2. Optimize the sameMap function

    @ahejlsberg
    ahejlsberg committed Jan 16, 2018
    Copy the full SHA
    d52fa71 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2018

  1. Merge branch 'master' into conditionalTypes 

    # Conflicts:
#	src/compiler/checker.ts
#	src/compiler/types.ts
#	tests/baselines/reference/api/tsserverlibrary.d.ts
#	tests/baselines/reference/api/typescript.d.ts
    @ahejlsberg
    ahejlsberg committed Jan 17, 2018
    Copy the full SHA
    4ec6fdd View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2018

  1. Separate code path for conditional type instantiation

    @ahejlsberg
    ahejlsberg committed Jan 18, 2018
    Copy the full SHA
    fd0dd6e View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2018

  1. Fix parsing

    @ahejlsberg
    ahejlsberg committed Jan 19, 2018
    Copy the full SHA
    c360c24 View commit details
    Browse the repository at this point in the history

  2. Disallow conditional type following 'extends'

    @ahejlsberg
    ahejlsberg committed Jan 19, 2018
    Copy the full SHA
    0e73240 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2018

  1. Add T is related to { [P in xxx]: T[P] } type relationship

    @ahejlsberg
    ahejlsberg committed Jan 20, 2018
    Copy the full SHA
    5204fd5 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @ahejlsberg
    ahejlsberg committed Jan 20, 2018
    Copy the full SHA
    eb314d0 View commit details
    Browse the repository at this point in the history

  3. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Jan 20, 2018
    Copy the full SHA
    cdd50d4 View commit details
    Browse the repository at this point in the history

  4. Revise comments

    @ahejlsberg
    ahejlsberg committed Jan 20, 2018
    Copy the full SHA
    fc7d1c3 View commit details
    Browse the repository at this point in the history

  5. Cache substitution types and remove erasure that was too eager

    @ahejlsberg
    ahejlsberg committed Jan 20, 2018
    Copy the full SHA
    f19959a View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2018

  1. Remove unnecessary caching of substitution types

    @ahejlsberg
    ahejlsberg committed Jan 21, 2018
    Copy the full SHA
    b869290 View commit details
    Browse the repository at this point in the history

  2. Shared code path for getConditionalType and instantiateConditionalType

    @ahejlsberg
    ahejlsberg committed Jan 21, 2018
    Copy the full SHA
    4c7ec3c View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. Only conditional types that check naked type parameter distribute ove… 

    …r unions
    @ahejlsberg
    ahejlsberg committed Jan 24, 2018
    Copy the full SHA
    b42c6b1 View commit details
    Browse the repository at this point in the history

  2. Fix bug in resolveMappedTypeMembers

    @ahejlsberg
    ahejlsberg committed Jan 24, 2018
    Copy the full SHA
    8e337b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. Implement type inference in conditional types

    @ahejlsberg
    ahejlsberg committed Jan 25, 2018
    Copy the full SHA
    d608941 View commit details
    Browse the repository at this point in the history

  2. Remove pointless fourslash tests

    @ahejlsberg
    ahejlsberg committed Jan 25, 2018
    Copy the full SHA
    490d656 View commit details
    Browse the repository at this point in the history

  3. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Jan 25, 2018
    Copy the full SHA
    4d62df4 View commit details
    Browse the repository at this point in the history

  4. Change precedence of 'infer T' to match 'keyof T'

    @ahejlsberg
    ahejlsberg committed Jan 25, 2018
    Copy the full SHA
    ef0c3b7 View commit details
    Browse the repository at this point in the history

  5. Check 'infer' declarations are in extends clause of conditional type

    @ahejlsberg
    ahejlsberg committed Jan 25, 2018
    Copy the full SHA
    f59f3a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2018

  1. Properly handle inferred type parameters in declaration emitter

    @ahejlsberg
    ahejlsberg committed Jan 26, 2018
    Copy the full SHA
    60c9249 View commit details
    Browse the repository at this point in the history

  2. Infer intersection types for multiple contravariant candidates

    @ahejlsberg
    ahejlsberg committed Jan 26, 2018
    Copy the full SHA
    e450212 View commit details
    Browse the repository at this point in the history

  3. Check for definitely false condition first

    @ahejlsberg
    ahejlsberg committed Jan 26, 2018
    Copy the full SHA
    fa6c4b7 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2018

  1. Cache 'any' instantiations for faster conditional type resolution

    @ahejlsberg
    ahejlsberg committed Jan 27, 2018
    Copy the full SHA
    edffb12 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2018

  1. Add definitelyAssignableRelation

    @ahejlsberg
    ahejlsberg committed Jan 30, 2018
    Copy the full SHA
    c6f0dfb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into conditionalTypes

    @ahejlsberg
    ahejlsberg committed Jan 30, 2018
    Copy the full SHA
    4f2b5f3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into conditionalTypes

    @ahejlsberg
    ahejlsberg committed Jan 30, 2018
    Copy the full SHA
    f990e4e View commit details
    Browse the repository at this point in the history

  4. Update to use TypeFlags.Instantiable in instantiateSymbol

    @ahejlsberg
    ahejlsberg committed Jan 30, 2018
    Copy the full SHA
    01516c8 View commit details
    Browse the repository at this point in the history

  5. Add tests

    @ahejlsberg
    ahejlsberg committed Jan 30, 2018
    Copy the full SHA
    34505c1 View commit details
    Browse the repository at this point in the history

  6. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Jan 30, 2018
    Copy the full SHA
    03a3847 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'conditionalTypes' into inferTypes 

    # Conflicts:
#	src/compiler/checker.ts
#	tests/cases/fourslash/completionInJSDocFunctionNew.ts
#	tests/cases/fourslash/completionInJSDocFunctionThis.ts
    @ahejlsberg
    ahejlsberg committed Jan 30, 2018
    Copy the full SHA
    7c241ba View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2018

  1. Always use strict rules for contravariant inferences

    @ahejlsberg
    ahejlsberg committed Jan 31, 2018
    Copy the full SHA
    5702f61 View commit details
    Browse the repository at this point in the history

  2. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Jan 31, 2018
    Copy the full SHA
    1275a20 View commit details
    Browse the repository at this point in the history

  3. Add more error case checks

    @ahejlsberg
    ahejlsberg committed Jan 31, 2018
    Copy the full SHA
    afec056 View commit details
    Browse the repository at this point in the history

  4. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Jan 31, 2018
    Copy the full SHA
    36a49ad View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2018

  1. Merge branch 'master' into conditionalTypes 

    # Conflicts:
#	src/compiler/checker.ts
    @ahejlsberg
    ahejlsberg committed Feb 3, 2018
    Copy the full SHA
    d4dc67a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'conditionalTypes' into inferTypes

    @ahejlsberg
    ahejlsberg committed Feb 3, 2018
    Copy the full SHA
    7034d67 View commit details
    Browse the repository at this point in the history

  3. Resolve to type in true branch for 'never extends never'

    @ahejlsberg
    ahejlsberg committed Feb 3, 2018
    Copy the full SHA
    7bb8cfe View commit details
    Browse the repository at this point in the history

  4. Add tests

    @ahejlsberg
    ahejlsberg committed Feb 3, 2018
    Copy the full SHA
    a712344 View commit details
    Browse the repository at this point in the history

  5. Accept new baselines

    @ahejlsberg
    ahejlsberg committed Feb 3, 2018
    Copy the full SHA
    04260d6 View commit details
    Browse the repository at this point in the history

  6. Properly classify output text in emitter

    @ahejlsberg
    ahejlsberg committed Feb 3, 2018
    Copy the full SHA
    4ae8445 View commit details
    Browse the repository at this point in the history