Skip to content

Conversation

@yuit
Copy link
Contributor

@yuit yuit commented Apr 12, 2015

No just the update in those two section. See this PR #1878 for the spec change

@DanielRosenwasser
Copy link
Member

In the future, we should link to the relevant sections at a spec snapshot and give details on what we're testing.

Are you writing tests for all of 3.8.2.2 and 6.4?

@yuit
Copy link
Contributor Author

yuit commented Apr 13, 2015

Forgot to do so. I have updated the description

@yuit yuit changed the title Conformance test for 3.8.2.2 and 6.4 Conformance test for Spec Change in Section 3.8.2.2 and 6.4 Apr 13, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this change, we want this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should merge in from master to ensure it doesn't get kept.

@yuit yuit changed the title Conformance test for Spec Change in Section 3.8.2.2 and 6.4 Conformance test for Spec Change in Section 3.8.2.2 parameter Declaration and 6.4 Destructuring parameter declarations Apr 16, 2015
yuit added a commit that referenced this pull request May 4, 2015
Conformance test for Spec Change in Section 3.8.2.2 parameter Declaration and 6.4 Destructuring parameter declarations
@yuit yuit merged commit fce012d into master May 4, 2015
@yuit yuit deleted the conformanceParameterDecl branch May 4, 2015 17:50
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants