Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Propagate saved variance flags from cached comparisons #31688
Watch mode vs batch mode was altering our check order and changing if we checked React's
@RyanCavanaugh probably - it's definitely a 3.5 regression and because it's caused by check order differences it's mega hard to debug what's going on - I wasn't even sure at first (since the type errors are kiiinda reasonable, especially if you don't know the subtleties of the "unreliable" variance markers) and had to debug for a few hours to track it back to this cause.
@ahejlsberg I've cleaned this up and was even able to remove some now redundant suspect code from when I added the
Here they are:
Comparison Report - master..31688