Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsound Array.concat() typings #33620

Open
wants to merge 3 commits into
base: master
from
Open

Conversation

@jablko
Copy link
Contributor

jablko commented Sep 26, 2019

Fixes #19535

@RyanCavanaugh

This comment has been minimized.

Copy link
Member

RyanCavanaugh commented Sep 26, 2019

@jablko we can't merge all these PRs independently - please make a roll-up PR with all the concat changes in one so we can actually test them. There should also be a unified test suite that clearly outlines the behaviors you want to change.

@jablko

This comment has been minimized.

Copy link
Contributor Author

jablko commented Sep 27, 2019

@RyanCavanaugh Sure thing: I've now created #33645 combining all of the Array.concat() changes

@jablko jablko force-pushed the jablko:patch-11 branch 3 times, most recently from c502726 to bd3b22e Sep 27, 2019
@jablko jablko force-pushed the jablko:patch-11 branch 3 times, most recently from 659822c to f4e78a6 Oct 5, 2019
@jablko jablko force-pushed the jablko:patch-11 branch 3 times, most recently from 7a5a93f to d8c12f7 Oct 16, 2019
@jablko jablko force-pushed the jablko:patch-11 branch from d8c12f7 to 4494088 Oct 27, 2019
@jablko jablko force-pushed the jablko:patch-11 branch from 4494088 to 23d2c49 Nov 4, 2019
@jablko jablko force-pushed the jablko:patch-11 branch 3 times, most recently from 0b7fa2f to 0ef07be Nov 13, 2019
@jablko jablko force-pushed the jablko:patch-11 branch 5 times, most recently from 7441f84 to 6194c9d Nov 22, 2019
@jablko jablko force-pushed the jablko:patch-11 branch from 6194c9d to 5e90a29 Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.